[qcoro] New port #33273

danvratil · 2023-08-19T16:10:19Z

danvratil · 2023-08-19T20:33:33Z

I disabled support for OSX for now, because Apple Clang compiler ICEs in Release build, I need to reproduce it in upstream CI and debug the problem further to be able to find out how to workaround the ICE.

Adela0814 · 2023-08-21T07:21:43Z

ports/qcoro/portfile.cmake

+vcpkg_from_github(
+    OUT_SOURCE_PATH SOURCE_PATH
+    REPO danvratil/qcoro
+    REF "v0.9.0"


Suggested change

REF "v0.9.0"

REF "v${VERSION}"

Adela0814 · 2023-08-21T07:25:34Z

ports/qcoro/0001-qt6-deprecated-qwebsocket-error.patch

+commit 1f420bb8f9f0028d1289143c4a51bcf8da88387d
+Author: Marius P <nmariusp1@gmail.com>
+Date:   Sat May 13 12:40:48 2023 +0300
+
+    qcorowebsocket replace QWebSocket::error with QWebSocket::errorOccurred
+
+    I build using cmake build configuration "Debug" not "RelWithDebInfo".
+    Building qcoro fails with error "qcoro/qcoro/websockets/qcorowebsocket.cpp:
+    35:73: error: ‘void QWebSocket::error(QAbstractSocket::SocketError)’
+    is deprecated: Use errorOccurred instead [-Werror=deprecated-declarations]".
+    Because "# Only enable strict warnings in debug mode
+    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wall -Wextra -Werror -pedantic")".
+


Please remove these lines.

OK, removed. I though I'd keep reference to the upstream commit that this patch contains.

Adela0814 · 2023-08-21T07:26:47Z

ports/qcoro/0001-qt6-deprecated-qwebsocket-error.patch

+index be9c1f7..c686d14 100644
+--- a/qcoro/websockets/qcorowebsocket.cpp
+++ b/qcoro/websockets/qcorowebsocket.cpp
+@@ -32,7 +32,13 @@ public:


Please submit the content of this patch to the upstream, we need to wait for their approval.

Github user names checks out to be upstream?

I'm the upstream :) This patch is already in the main branch, just wasn't included in 0.9.0 release. It will be dropped once 0.10.0 is out.

Adela0814 · 2023-08-21T07:30:15Z

ports/qcoro/vcpkg.json

+  "homepage": "https://www.github.com/danvratil/qcoro",
+  "documentation": "https://qcoro.dvratil.cz",
+  "license": "MIT",
+  "supports": "!osx",


Please move this to ci. baseline instead of in the supports field. Because upstream supports OSX.

Done, hopefully I did it correctly.

Adela0814 · 2023-08-21T07:33:37Z

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Triggers ICE in release build, but OSX is officially supported, so just expect CI to fail.

Adela0814 · 2023-08-23T06:22:44Z

@danvratil I encountered an error while testing usage:

1> [CMake] CMake Error at E:/4/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package):
1> [CMake]   By not providing "FindQCoro6Coro.cmake" in CMAKE_MODULE_PATH this project
1> [CMake]   has asked CMake to find a package configuration file provided by
1> [CMake]   "QCoro6Coro", but CMake did not find one.
1> [CMake] 
1> [CMake]   Could not find a package configuration file provided by "QCoro6Coro" with
1> [CMake]   any of the following names:
1> [CMake] 
1> [CMake]     QCoro6CoroConfig.cmake
1> [CMake]     qcoro6coro-config.cmake
1> [CMake] 
1> [CMake]   Add the installation prefix of "QCoro6Coro" to CMAKE_PREFIX_PATH or set
1> [CMake]   "QCoro6Coro_DIR" to a directory containing one of the above files.  If
1> [CMake]   "QCoro6Coro" provides a separate development package or SDK, be sure it has
1> [CMake]   been installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.24/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
1> [CMake]   E:/4/vcpkg/installed/x64-windows/share/QCoro6Core/QCoro6CoreConfig.cmake:30 (find_dependency)
1> [CMake]   E:/4/vcpkg/scripts/buildsystems/vcpkg.cmake:855 (_find_package)
1> [CMake]   CMakeTest/CMakeLists.txt:15 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> [CMake] See also "E:/CMakeTest/out/build/x64-debug/CMakeFiles/CMakeOutput.log".
1> [CMake] See also "E:/CMakeTest/out/build/x64-debug/CMakeFiles/CMakeError.log".
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="E:\CMakeTest\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" -DCMAKE_TOOLCHAIN_FILE="E:/4/vcpkg/scripts/buildsystems/vcpkg.cmake" "E:\CMakeTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="E:\CMakeTest\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx64/x64/cl.exe"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" -DCMAKE_TOOLCHAIN_FILE="E:/4/vcpkg/scripts/buildsystems/vcpkg.cmake" "E:\CMakeTest" 2>&1"' returned with exit code: 1'.

Usage:

qcoro-qt6 provides CMake targets:

    find_package(QCoro6Core CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::Core)

    find_package(QCoro6DBus CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::DBus)

    find_package(QCoro6Network CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::Network)

    find_package(QCoro6Qml CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::Qml)

    find_package(QCoro6Quick CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::Quick)

    find_package(QCoro6Test CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::Test)

    find_package(QCoro6WebSockets CONFIG REQUIRED)
    target_link_libraries(main PRIVATE QCoro6::WebSockets)

Adela0814 · 2023-08-24T10:02:46Z

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Adela0814 · 2023-10-08T07:34:37Z

All feature tested pass on the following triplets:

x64-windows
x64-windows-static
x86-windows

Usage tested pass on x64-windows.

BillyONeal · 2023-10-09T23:21:17Z

Thanks for the new port and 'confirming with upstream' that the patch was OK :)

Results from build: https://dev.azure.com/vcpkg/public/_build/results?buildId=95281 PASSING, REMOVE FROM FAIL LIST: qcoro:x64-osx (/Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt). Caused by microsoft#33273 The comment says that it's an ICE but it passed in CI; this might be a form of intermittent compiler crash. If we get a failure next time we should change this to skip instead.

Results from build: https://dev.azure.com/vcpkg/public/_build/results?buildId=95281 PASSING, REMOVE FROM FAIL LIST: qcoro:x64-osx (/Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt). Caused by #33273 The comment says that it's an ICE but it passed in CI; this might be a form of intermittent compiler crash. If we get a failure next time we should change this to skip instead.

Results from build: https://dev.azure.com/vcpkg/public/_build/results?buildId=95281 PASSING, REMOVE FROM FAIL LIST: qcoro:x64-osx (/Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt). Caused by microsoft#33273 The comment says that it's an ICE but it passed in CI; this might be a form of intermittent compiler crash. If we get a failure next time we should change this to skip instead.

danvratil marked this pull request as draft August 19, 2023 18:03

[qcoro-qt6] New port

4843fc5

danvratil force-pushed the qcoro-qt6 branch from 29174cc to 4843fc5 Compare August 19, 2023 20:30

danvratil marked this pull request as ready for review August 19, 2023 20:38

danvratil mentioned this pull request Aug 19, 2023

Add this library to vcpkg danvratil/qcoro#185

Closed

danvratil changed the title ~~[qcoro-qt6] New port~~ [qcoro] New port Aug 20, 2023

danvratil force-pushed the qcoro-qt6 branch from c538f90 to da53097 Compare August 20, 2023 15:00

Rename the port to qcoro

c15f7ed

danvratil force-pushed the qcoro-qt6 branch from da53097 to c15f7ed Compare August 20, 2023 15:05

Cheney-W assigned Adela0814 Aug 21, 2023

Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 21, 2023

Adela0814 suggested changes Aug 21, 2023

View reviewed changes

Adela0814 marked this pull request as draft August 21, 2023 07:33

danvratil added 4 commits August 21, 2023 16:36

Clean up upstream patch

3843339

Add x86-osx=failed to ci.baseline

2668ef4

Triggers ICE in release build, but OSX is officially supported, so just expect CI to fail.

Use ${VERSION} in portfile

7f8a017

Update version

db275e5

danvratil marked this pull request as ready for review August 21, 2023 20:16

Adela0814 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Aug 22, 2023

Adela0814 marked this pull request as draft August 24, 2023 10:02

danvratil added 2 commits October 1, 2023 15:51

Add missing QCoro6Coro cmake module

e81842d

Update version

e007117

danvratil marked this pull request as ready for review October 6, 2023 15:04

Adela0814 approved these changes Oct 8, 2023

View reviewed changes

Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 8, 2023

BillyONeal merged commit 848006d into microsoft:master Oct 9, 2023
15 checks passed

BillyONeal mentioned this pull request Oct 11, 2023

Build Fixes 2023-10-11. #34428

Merged

clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023

[qcoro] New port (microsoft#33273)

feac4b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[qcoro] New port #33273

[qcoro] New port #33273

danvratil commented Aug 19, 2023

danvratil commented Aug 19, 2023

Adela0814 Aug 21, 2023

danvratil Aug 21, 2023

Adela0814 Aug 21, 2023

danvratil Aug 21, 2023

Adela0814 Aug 21, 2023

Neumann-A Aug 21, 2023

danvratil Aug 21, 2023

Adela0814 Aug 21, 2023

danvratil Aug 21, 2023

Adela0814 commented Aug 21, 2023

Adela0814 commented Aug 23, 2023

Adela0814 commented Aug 24, 2023

Adela0814 commented Oct 8, 2023

BillyONeal commented Oct 9, 2023

[qcoro] New port #33273

[qcoro] New port #33273

Conversation

danvratil commented Aug 19, 2023

danvratil commented Aug 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Adela0814 commented Aug 21, 2023

Adela0814 commented Aug 23, 2023

Adela0814 commented Aug 24, 2023

Adela0814 commented Oct 8, 2023

BillyONeal commented Oct 9, 2023