[libdjinterop] update to 0.16.0 #20136

Be-ing · 2021-09-13T15:18:08Z

Describe the pull request

What does your PR fix?

Fixes outdated libdjinterop package
Which triplets are supported/not supported? Have you updated the CI baseline?

all
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

Be-ing · 2021-09-13T16:33:33Z

Is the sqlite3 package not installing a pkgconfig file?

Building package libdjinterop[core]:x64-linux...
-- Downloading https://github.com/xsco/libdjinterop/archive/0.16.0.tar.gz -> xsco-libdjinterop-0.16.0.tar.gz...
-- Extracting source /mnt/vcpkg-ci/downloads/xsco-libdjinterop-0.16.0.tar.gz
-- Using source at /mnt/vcpkg-ci/buildtrees/libdjinterop/src/0.16.0-c2f5fdd1ce.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Fixing pkgconfig file: /mnt/vcpkg-ci/packages/libdjinterop_x64-linux/lib/pkgconfig/djinterop.pc
-- pkg_cfg_cmd call with:/bin/pkg-config --exists djinterop failed
-- ENV{PKG_CONFIG_PATH}:/mnt/vcpkg-ci/installed/x64-linux/lib/pkgconfig:/mnt/vcpkg-ci/installed/x64-linux/share/pkgconfig:/mnt/vcpkg-ci/packages/libdjinterop_x64-linux/lib/pkgconfig:/mnt/vcpkg-ci/packages/libdjinterop_x64-linux/share/pkgconfig
-- pkg-config call failed with error code:1
-- pkg-config output:
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:83 (message):
  pkg-config error output:Package sqlite3 was not found in the pkg-config
  search path.

  Perhaps you should add the directory containing `sqlite3.pc'

  to the PKG_CONFIG_PATH environment variable

  Package 'sqlite3', required by 'djinterop', not found
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:184 (vcpkg_fixup_pkgconfig_check_files)
  ports/libdjinterop/portfile.cmake:13 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:140 (include)

Be-ing · 2021-09-13T16:35:05Z

I can't reproduce the x64-linux build error locally. Why is it failing on CI?

Be-ing · 2021-09-13T16:36:29Z

Indeed, the sqlite3 package does not install a pkgconfig file. I suppose it worked locally on x64-linux because it picked up my system sqlite3 pkgconfig file.

Be-ing · 2021-09-13T16:54:31Z

The sqlite3 port builds from the SQLite "amalgamation" source which does not include a pkgconfig file like the SQLite autotools source.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c26477297ce1a9d67844e86bf0cda0e7741bd169 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 1a115f3..9143da5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6166,7 +6166,7 @@
     },
     "sqlite3": {
       "baseline": "3.36.0",
-      "port-version": 0
+      "port-version": 1
     },
     "sqlitecpp": {
       "baseline": "3.1.1",
diff --git a/versions/s-/sqlite3.json b/versions/s-/sqlite3.json
index 2154ae8..4e64d95 100644
--- a/versions/s-/sqlite3.json
+++ b/versions/s-/sqlite3.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "49efb0a409bd7f57c153b182514c548256c1d62a",
+      "version": "3.36.0",
+      "port-version": 1
+    },
     {
       "git-tree": "c23525b0204e11a56d40cbb0b7fa68861450df04",
       "version": "3.36.0",

dg0yt

Nice to add sqlite3 pc file.

ports/sqlite3/sqlite3.pc.in

Be-ing · 2021-09-14T20:20:45Z

@dg0yt could you take another look at how the sqlite3 pkgconfig file is handled now?

JonLiu1993 · 2021-09-15T02:12:38Z

@Be-ing ,I installed sqlite3 locally, and the .pc file should be generated under the ${CURRENT_PACKAGES_DIR}/lib/pkgconfig/ folder instead of under the ${CURRENT_PACKAGES_DIR}/share/pkgconfig file. Could you modify the path?

dg0yt

I would prefer to remove all references to zlib unless properly used in an optional feature.

ports/sqlite3/sqlite3.pc.in

ports/sqlite3/portfile.cmake

BillyONeal · 2021-09-15T18:42:55Z

/azp run

azure-pipelines · 2021-09-15T18:43:04Z

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993 · 2021-09-16T10:27:59Z

@Be-ing ,Could you please take a look?
install-x64-osx-dbg-err.log
install-x64-osx-dbg-out.log

Be-ing · 2021-09-16T13:08:12Z

install: mkdir /Users/vagrant/Data/packages/python3_x64-osx/Users/vagrant/Data/installed/x64-osx/debug/lib: File exists
make: *** [altbininstall] Error 71

I don't think this is related to the changes in this branch??

BillyONeal · 2021-09-17T00:56:53Z

/azp run

azure-pipelines · 2021-09-17T00:57:02Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2021-09-17T00:59:18Z

I'm sorry it seems like our CI has been unhappy today. Having an issue where sometimes bazel building tensorflow breaks out of our job and causes that build node to fail a bunch of things after. I have not seen the specific macos issue reported here before, but python3 is not in libdjinterop 's cone of destruction so I've simply requeued the build.

Be-ing · 2021-09-17T22:39:13Z

CI passed now.

ports/sqlite3/CMakeLists.txt

Linux distributions typically use the SQLite autoconf package, but this port uses the SQLite amalgamation package with a custom CMakeLists.txt so the port needs to take care of installing the pkgconfig file.

strega-nil-ms · 2021-09-22T20:00:02Z

Thanks @Be-ing!

[libdjinterop] update to 0.16.0

f2d2555

Be-ing mentioned this pull request Sep 13, 2021

CMake: always set CMAKE_OSX_DEPLOYMENT_TARGET=10.12 daschuer/mixxx#69

Merged

github-actions bot approved these changes Sep 13, 2021

View reviewed changes

github-actions bot requested changes Sep 13, 2021

View reviewed changes

Be-ing force-pushed the libdjinterop_0.16.0 branch from 66bd0db to b635ee3 Compare September 13, 2021 17:40

github-actions bot approved these changes Sep 13, 2021

View reviewed changes

dg0yt reviewed Sep 13, 2021

View reviewed changes

ports/sqlite3/sqlite3.pc.in Outdated Show resolved Hide resolved

Be-ing force-pushed the libdjinterop_0.16.0 branch from b635ee3 to 667ddd7 Compare September 13, 2021 21:07

github-actions bot approved these changes Sep 13, 2021

View reviewed changes

JonLiu1993 self-assigned this Sep 14, 2021

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 14, 2021

Be-ing mentioned this pull request Sep 14, 2021

Use 2.4 vcpkg branch for MacOS and Windows mixxxdj/mixxx#4225

Merged

JonLiu1993 added the requires:author-response label Sep 15, 2021

dg0yt reviewed Sep 15, 2021

View reviewed changes

ports/sqlite3/sqlite3.pc.in Outdated Show resolved Hide resolved

ports/sqlite3/portfile.cmake Outdated Show resolved Hide resolved

Be-ing force-pushed the libdjinterop_0.16.0 branch from 667ddd7 to 7e34711 Compare September 15, 2021 17:32

github-actions bot approved these changes Sep 15, 2021

View reviewed changes

dg0yt reviewed Sep 15, 2021

View reviewed changes

ports/sqlite3/portfile.cmake Outdated Show resolved Hide resolved

dg0yt reviewed Sep 15, 2021

View reviewed changes

ports/sqlite3/portfile.cmake Outdated Show resolved Hide resolved

Be-ing force-pushed the libdjinterop_0.16.0 branch from 7e34711 to 2e8ce33 Compare September 16, 2021 03:34

github-actions bot approved these changes Sep 16, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 17, 2021

dg0yt mentioned this pull request Sep 17, 2021

[vcpkg-ci] Add AZP logging markup for skipped ports #19259

Closed

JonLiu1993 approved these changes Sep 18, 2021

View reviewed changes

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2021

dg0yt reviewed Sep 18, 2021

View reviewed changes

ports/sqlite3/CMakeLists.txt Outdated Show resolved Hide resolved

JonLiu1993 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 18, 2021

[sqlite3] add pkgconfig file

4ead062

Linux distributions typically use the SQLite autoconf package, but this port uses the SQLite amalgamation package with a custom CMakeLists.txt so the port needs to take care of installing the pkgconfig file.

Be-ing force-pushed the libdjinterop_0.16.0 branch from 2e8ce33 to 4ead062 Compare September 20, 2021 19:51

github-actions bot approved these changes Sep 20, 2021

View reviewed changes

JonLiu1993 approved these changes Sep 22, 2021

View reviewed changes

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 22, 2021

strega-nil-ms approved these changes Sep 22, 2021

View reviewed changes

strega-nil-ms merged commit 93885af into microsoft:master Sep 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libdjinterop] update to 0.16.0 #20136

[libdjinterop] update to 0.16.0 #20136

Be-ing commented Sep 13, 2021

Be-ing commented Sep 13, 2021 •

edited

Loading

Be-ing commented Sep 13, 2021

Be-ing commented Sep 13, 2021

Be-ing commented Sep 13, 2021

github-actions bot left a comment

dg0yt left a comment

Be-ing commented Sep 14, 2021

JonLiu1993 commented Sep 15, 2021 •

edited

Loading

dg0yt left a comment

BillyONeal commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

JonLiu1993 commented Sep 16, 2021

Be-ing commented Sep 16, 2021

BillyONeal commented Sep 17, 2021

azure-pipelines bot commented Sep 17, 2021

BillyONeal commented Sep 17, 2021

Be-ing commented Sep 17, 2021

strega-nil-ms commented Sep 22, 2021

[libdjinterop] update to 0.16.0 #20136

[libdjinterop] update to 0.16.0 #20136

Conversation

Be-ing commented Sep 13, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Be-ing commented Sep 13, 2021 • edited Loading

Be-ing commented Sep 13, 2021

Be-ing commented Sep 13, 2021

Be-ing commented Sep 13, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt left a comment

Choose a reason for hiding this comment

Be-ing commented Sep 14, 2021

JonLiu1993 commented Sep 15, 2021 • edited Loading

dg0yt left a comment

Choose a reason for hiding this comment

BillyONeal commented Sep 15, 2021

azure-pipelines bot commented Sep 15, 2021

JonLiu1993 commented Sep 16, 2021

Be-ing commented Sep 16, 2021

BillyONeal commented Sep 17, 2021

azure-pipelines bot commented Sep 17, 2021

BillyONeal commented Sep 17, 2021

Be-ing commented Sep 17, 2021

strega-nil-ms commented Sep 22, 2021

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Be-ing commented Sep 13, 2021 •

edited

Loading

JonLiu1993 commented Sep 15, 2021 •

edited

Loading