-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg/script] get infos from installed ports #17029
Conversation
@@ -39,17 +39,20 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | |||
opengl WITH_OPENGL | |||
vtk WITH_VTK | |||
) | |||
|
|||
x_vcpkg_get_port_info(PORTS qhull flann boost-system) | |||
string(COMPARE EQUAL "${boost-system_LIBRARY_LINKAGE}" "dynamic" BOOST_LINKAGE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (boost) needs to be checked by someone.
Usually, this is to set macros for the headers or to change searched-for library names -- in both these cases, we should be solving the problem in the dependency (hardcoding the correct macro setting or using an indirection layer like |
I just checked the variable for boost and it was setting up the find_package call + adding some compile definitions. Also there are more ports than pcl requiring the information since I can remember saying 'this won't work correctly in a custom triplet a few times in different prs' |
I added requires:discussion back so that we look at Neumann-A's reply to Robert |
To our understanding, there are 2 expected use cases for this proposal:
We admit that there may be other use cases than enumerated above which might argue to revisit this. However. we believe the above cases are better served as enumerated above. |
some ports require insight into their dependent ports to be configured correctly. One such example is pcl
closes #8269