Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass important env variable for proxy support in pip #1475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Aug 12, 2024

as per title

@cenit cenit changed the title pass important env variables for proxy support in pip and cuda new releases pass important env variable for proxy support in pip Aug 12, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Aug 12, 2024

So we can fix online builds, but we still can't build offline when it comes to pip an friends.

@BillyONeal
Copy link
Member

Can you point to docs for these and/or what the customer expectation for them is? In general we should be trying to route this stuff through x-download although it's understandable we might be unable to do so for pip.

To be clear, my concern would be customers expecting these variables to control other vcpkg downloads unrelated to pip and they not doing so, for instance, if we select the WinHTTP backend.

@cenit
Copy link
Contributor Author

cenit commented Aug 31, 2024

https://pip.pypa.io/en/stable/topics/https-certificates/

you mean something like this?
the problem is that unless you have the very very recent pip 24.2+ coupled with a recent python interpreter already installed (not the case for vcpkg python tooling), corporate proxies are not supported without these env variables defined. But if you have your variables defined and you expect to make them enable vcpkg python tooling, you are welcomed with an error since vcpkg masks most of the env variables

@BillyONeal
Copy link
Member

But if you have your variables defined and you expect to make them enable vcpkg python tooling, you are welcomed with an error since vcpkg masks most of the env variables

Would it make sense for folks in this situation to opt-in to it by using VCPKG_KEEP_ENV_VARS?

@cenit
Copy link
Contributor Author

cenit commented Sep 21, 2024

is there any rule written anywhere to say what should pass always if defined and what not and the user has to opt-in?
this env variable is not modifying the build but just enabling tools to work in specific environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants