Fix binary caching push failures (set BinaryProviders::nuget_repo
) & remove unused field
#1360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryProviders::nuget_repo
wasn't getting set anywhere, even thoughBinaryCache::push_success()
uses it.Also removed
BinaryConfigParserState::nuget_repo_info
which was unused.Without this change, pushing any package into my GHE nuget cache resulted in these kinds of errors (started happening 3+ months ago on my Ubuntu 20.04 GitHub Actions runner):
Potential reviewer: @BillyONeal