Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary caching push failures (set BinaryProviders::nuget_repo) & remove unused field #1360

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

VelocityRa
Copy link
Contributor

@VelocityRa VelocityRa commented Mar 4, 2024

BinaryProviders::nuget_repo wasn't getting set anywhere, even though BinaryCache::push_success() uses it.
Also removed BinaryConfigParserState::nuget_repo_info which was unused.

Without this change, pushing any package into my GHE nuget cache resulted in these kinds of errors (started happening 3+ months ago on my Ubuntu 20.04 GitHub Actions runner):

Pushing vcpkg-cmake-config_x64-linux.2022.2.6-vcpkga66b0ae909b0dfb01b299ab9de46b1e919ddf11d8565c40906a893993d6b3ce8.nupkg to 'https://nuget.git.[redacted]'...
  PUT https://nuget.git.[redacted]
WARNING: No destination repository detected. Ensure the source project has a 'RepositoryUrl' property defined. If you're using a nuspec file, ensure that it has a repository element with the required 'type' and 'url' attributes.
  BadRequest https://nuget.git.[redacted] 283ms
Response status code does not indicate success: 400 (Bad Request).

Potential reviewer: @BillyONeal

The former wasn't getting set anywhere even though `BinaryCache::push_success()` uses it.

Also remove unused `BinaryConfigParserState::nuget_repo_info` field.
@VelocityRa VelocityRa changed the title binarycaching: Set BinaryProviders::nuget_repo & remove unused field Fix binary caching push failures (set BinaryProviders::nuget_repo & remove unused field) Mar 4, 2024
@VelocityRa VelocityRa changed the title Fix binary caching push failures (set BinaryProviders::nuget_repo & remove unused field) Fix binary caching push failures (set BinaryProviders::nuget_repo) & remove unused field Mar 4, 2024
@BillyONeal BillyONeal merged commit 56b4a5b into microsoft:main Mar 7, 2024
5 checks passed
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants