[z-applocal] Reduce nonexistent and non-PE files to warnings. #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas1664
reviewed
Nov 10, 2023
| ExpectedL<Unit> read_pe_signature_and_get_coff_header_offset(ReadFilePointer& f) | ||
| // reads f as a portable executable and checks for magic number signatures. | ||
| // if an I/O error occurs, returns the error; otherwise, | ||
| // returns iff signatures match |
There was a problem hiding this comment.
Suggested change
| // returns iff signatures match | |
| // returns if signatures match |
There was a problem hiding this comment.
This was intentional (iff == if and only if)
| AppLocalInvocation invocation(real_filesystem, | ||
|
|
||
| // the first binary is special in that it might not be a DLL or might not exist | ||
| const Path target_binary_path = target_binary->second; |
There was a problem hiding this comment.
Suggested change
| const Path target_binary_path = target_binary->second; | |
| const Path& target_binary_path = target_binary->second; |
There was a problem hiding this comment.
I think that would be wrong because there is a conversion intended here. (target_binary->second is a std::string, not a Path)
There was a problem hiding this comment.
In this case I'd use const Path target_binary_path(target_binary->second) to make the conversion more obvious.
ras0219-msft
approved these changes
Nov 21, 2023
| Checks::exit_fail(VCPKG_LINE_INFO); | ||
| } | ||
|
|
||
| auto maybe_dll_metadata = vcpkg::try_read_dll_metadata(dll_file).value_or_exit(VCPKG_LINE_INFO); |
There was a problem hiding this comment.
Why not use try_read_dll_metadata_required?
There was a problem hiding this comment.
Because the whole point of this is to use the not required one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer tried to turn on our
z-applocalbuilt in replacement forapplocal.ps1and it failed onvcxprojs that produce no outputs, andvcxprojs that make static libraries in their testing. This change reduces both results to warnings and explains when there's an MZ signature mismatch better.Before:
After: