Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Container&& overload for Util::Vectors::append #1254

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Add Container&& overload for Util::Vectors::append #1254

merged 8 commits into from
Nov 1, 2023

Conversation

Thomas1664
Copy link
Contributor

Util::Vectors::append always copied although move was intended in most cases.

BillyONeal
BillyONeal requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right fix is to make append move if the container is an rvalue, not to delete the function entirely.

The change to remove the initializer_list seems good to me

src/vcpkg/commands.autocomplete.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.build.cpp Show resolved Hide resolved
src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved
@Thomas1664 Thomas1664 changed the title Remove Util::Vectors::append Add Container&& overload for Util::Vectors::append Oct 31, 2023
@BillyONeal BillyONeal merged commit 13b138a into microsoft:main Nov 1, 2023
5 checks passed
@BillyONeal
Copy link
Member

Thanks!

@Thomas1664 Thomas1664 deleted the remove-append branch November 1, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas1664 @BillyONeal