Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash while parsing malformed manifest files and make errors prettier #1219

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Fix crash while parsing malformed manifest files and make errors prettier #1219

merged 6 commits into from
Oct 2, 2023

Commits on Sep 28, 2023

  1. Fix crash while parsing malformed manifest files. 

    Alternative to microsoft#1211

Fixes microsoft/vcpkg#33973

I'm not entirely happy with this because it emits extra 'mismatched type' warnings like $.dependencies[0].features[0]: mismatched type: expected a feature in a dependency .
    @BillyONeal
    BillyONeal committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    68122ce View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Remove semantic constraints on the deserialized type and add specific… 

    … errors.
    @BillyONeal
    BillyONeal committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b04a5b2 View commit details
    Browse the repository at this point in the history

  2. Make the e2e tests into unit tests and make the errors a bit prettier.

    @BillyONeal
    BillyONeal committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    80fa913 View commit details
    Browse the repository at this point in the history

  3. Burninate Expr::Empty

    @BillyONeal
    BillyONeal committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    918269b View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Merge remote-tracking branch 'origin/main' into add-error-for-bad-dep… 

    …endency-features
    @BillyONeal
    BillyONeal committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    7f9ac40 View commit details
    Browse the repository at this point in the history

  2. Code review feedback

    @BillyONeal
    BillyONeal committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    582382f View commit details
    Browse the repository at this point in the history