-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add z-changelog; replacement for scripts/Get-Changelog.ps1 #1200
Conversation
# Conflicts: # src/vcpkg/registries.cpp
1. Run 'auto generate release notes' | ||
1. Change `## New Contributors` to `#### New Contributors` | ||
1. Copy the contents to the end of `path/to/results.md` (the `#### New Contributors` part should line up) | ||
1. Change the link to the most recent CI build, and copy number of successful ports into the table at the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems likely to cause a mistake (forget to fill in the correct final table); I'd drop it.
edit: suggestion is to drop this specific step. Leave the table empty (or nonexistent) until the final numbers are ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying to drop the table entirely? I think @AugP said he liked the table...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be out of scope for this PR. Are there tests for portsdiff
? I feel like we need to add them if not: portsdiff
is not an experimental command, which means it should be supported on all platforms. I was not able to get portsdiff
working on Linux locally.
I agree tests would be good but I don't have great ideas on doing so :/ |
Looks like there's a |
portsdiff
portsdiff
portsdiff
: