Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z-changelog; replacement for scripts/Get-Changelog.ps1 #1200

Merged
merged 11 commits into from
Oct 4, 2023

Conversation

BillyONeal
Copy link
Member

  • Built on the 'bones' of portsdiff
  • Also implemented the single pass algorithm for portsdiff
  • Fixed bad newlines in portsdiff:

example output

  • Removed the version numbers for the 'removed' ports output because the version at the previous snapshot is meaningless; the meaningful version would be the last version but we don't know that.

1. Run 'auto generate release notes'
1. Change `## New Contributors` to `#### New Contributors`
1. Copy the contents to the end of `path/to/results.md` (the `#### New Contributors` part should line up)
1. Change the link to the most recent CI build, and copy number of successful ports into the table at the top.
Copy link
Contributor

@ras0219-msft ras0219-msft Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems likely to cause a mistake (forget to fill in the correct final table); I'd drop it.

edit: suggestion is to drop this specific step. Leave the table empty (or nonexistent) until the final numbers are ready.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying to drop the table entirely? I think @AugP said he liked the table...

src/vcpkg/commands.z-changelog.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@data-queue data-queue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be out of scope for this PR. Are there tests for portsdiff? I feel like we need to add them if not: portsdiff is not an experimental command, which means it should be supported on all platforms. I was not able to get portsdiff working on Linux locally.

@BillyONeal
Copy link
Member Author

May be out of scope for this PR. Are there tests for portsdiff? I feel like we need to add them if not: portsdiff is not an experimental command, which means it should be supported on all platforms. I was not able to get portsdiff working on Linux locally.

I agree tests would be good but I don't have great ideas on doing so :/

@BillyONeal
Copy link
Member Author

May be out of scope for this PR. Are there tests for portsdiff? I feel like we need to add them if not: portsdiff is not an experimental command, which means it should be supported on all platforms. I was not able to get portsdiff working on Linux locally.

[DEBUG] 1001: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg -c core.autocrlf=false cat-file -t HEAD)
[DEBUG] 1001: cmd_execute_and_stream_data() returned 0 after     1479 us
[DEBUG] 1002: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg -c core.autocrlf=false cat-file -t HEAD~10)
[DEBUG] 1002: cmd_execute_and_stream_data() returned 0 after     1371 us
[DEBUG] 1003: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg/ports-HEAD -c core.autocrlf=false checkout HEAD -f -q -- ".\\ports" .vcpkg-root)
[DEBUG] 1003: cmd_execute_and_stream_data() returned 1 after     4097 us
[DEBUG] 1004: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg/ports-HEAD -c core.autocrlf=false reset)
[DEBUG] 1004: cmd_execute_and_stream_data() returned 0 after    14753 us
[DEBUG] 1005: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg/ports-HEAD~10 -c core.autocrlf=false checkout HEAD~10 -f -q -- ".\\ports" .vcpkg-root)
[DEBUG] 1005: cmd_execute_and_stream_data() returned 1 after     4810 us
[DEBUG] 1006: execute_process(/usr/bin/git --git-dir=/home/bion/vcpkg/.git --work-tree=/home/bion/vcpkg/ports-HEAD~10 -c core.autocrlf=false reset)
[DEBUG] 1006: cmd_execute_and_stream_data() returned 0 after    14850 us

Looks like there's a \\ that needs to be / here

@BillyONeal BillyONeal merged commit 96851de into microsoft:main Oct 4, 2023
5 checks passed
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Oct 4, 2023
@BillyONeal BillyONeal deleted the changelog branch October 4, 2023 05:51
BillyONeal added a commit to microsoft/vcpkg that referenced this pull request Oct 4, 2023
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants