Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch64 support #1149

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Add loongarch64 support #1149

merged 1 commit into from
Aug 12, 2023

Conversation

haowuge
Copy link
Contributor

@haowuge haowuge commented Aug 3, 2023

This PR allows using vcpkg on LoongArch machines (loongarch32/64). Tested with Gentoo Linux 2.14 (loongarch64 GNU/Linux / Loongson-3A5000-HV-7A2000-1w-V0.1-EVB)

Tested ports:

vcpkg list
7zip:loongarch64-linux                            22.01#1             Library for archiving file with a high compressi...
bzip2:loongarch64-linux                           1.0.8#4             bzip2 is a freely available, patent free, high-q...
bzip2[tool]:loongarch64-linux                                         Builds bzip2 executable
curl:loongarch64-linux                            8.2.0               A library for transferring data with URLs
curl[non-http]:loongarch64-linux                                      Enables protocols beyond HTTP/HTTPS/HTTP2
curl[openssl]:loongarch64-linux                                       SSL support (OpenSSL)
curl[ssl]:loongarch64-linux                                           Default SSL backend
cxxopts:loongarch64-linux                         3.1.1               This is a lightweight C++ option parser library,...
fmt:loongarch64-linux                             10.0.0              Formatting library for C++. It can be used as a ...
magic-enum:loongarch64-linux                      0.9.2               Header-only C++17 library provides static reflec...
openssl:loongarch64-linux                         3.1.1#1             OpenSSL is an open source project that provides ...
vcpkg-cmake-config:loongarch64-linux              2022-02-06#1        
vcpkg-cmake-get-vars:loongarch64-linux            2023-03-02          
vcpkg-cmake:loongarch64-linux                     2023-05-04          
yasm:loongarch64-linux                            1.3.0#5             Yasm is a complete rewrite of the NASM assembler...
yasm[tools]:loongarch64-linux                                         Build yasm tools
zlib:loongarch64-linux                            1.2.13              A compression library

@haowuge
Copy link
Contributor Author

haowuge commented Aug 3, 2023

@microsoft-github-policy-service agree company="BitMOE"

@haowuge
Copy link
Contributor Author

haowuge commented Aug 3, 2023

@microsoft-github-policy-service agree

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said you tested on Gentoo but the edits are in coffilereader which I don't believe is used on Linux... what input did this get tested on?

include/vcpkg/base/cofffilereader.h Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

You said you tested on Gentoo but the edits are in coffilereader which I don't believe is used on Linux... what input did this get tested on?

To clarify, I'm just trying to understand what testing was done, not necessarily that any code needs to change. If we don't have testing of a loongarch Windows binary but we're just adding a value to a table that's documented in the official spec and not otherwise using the result, that can be OK; I just wanted to make sure I understood the situation.

@BillyONeal BillyONeal changed the title add_loongarch64_support Add loongarch64 support Aug 12, 2023
@BillyONeal BillyONeal merged commit 5679873 into microsoft:main Aug 12, 2023
5 checks passed
@BillyONeal
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants