Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: T&, std::move, ref_t emplace_back(...) #1140

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Cleanup: T&, std::move, ref_t emplace_back(...) #1140

merged 5 commits into from
Jul 31, 2023

Conversation

Thomas1664
Copy link
Contributor

  • Fix more cases of unneeded copies due to missing &
  • Prefer move over copy
  • Cosmetic change: Prove that C++17's reference_type emplace_back() actually works

https://en.cppreference.com/w/cpp/compiler_support/17#C.2B.2B17_library_features
Search for P0084R2.

@BillyONeal
Copy link
Member

Thanks!

@BillyONeal BillyONeal merged commit ec414a7 into microsoft:main Jul 31, 2023
5 checks passed
@Thomas1664 Thomas1664 deleted the cleanup-2 branch August 1, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas1664 @BillyONeal