Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the vcpkg-find-acquire-program test port. #1130

Merged

Conversation

BillyONeal
Copy link
Member

Hopefully resolves test failures in #1129 -- asset caching is not turned on in the tool repo so testing things that need lots of external servers is problematic.

This was added back when the tool and registry were in the same repo in attempt to validate registry changes, not tool changes. As a result it doesn't really belong here.

The one thing that might also have been tested here is handling of old CONTROL files ports so I added an explicit test port for that.

Hopefully resolves test failures in microsoft#1129 -- asset caching is not turned on in the tool repo so testing things that need lots of external servers is problematic.

This was added back when the tool and registry were in the same repo in attempt to validate *registry* changes, not tool changes. As a result it doesn't really belong here.

The one thing that might also have been tested here is handling of old CONTROL files ports so I added an explicit test port for that.
@BillyONeal BillyONeal merged commit 7873dc4 into microsoft:main Jul 17, 2023
5 checks passed
@BillyONeal BillyONeal deleted the delete-find-acquire-program-test branch July 17, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants