Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building against different fmt versions #1117

Closed
wants to merge 1 commit into from
Closed

Allow building against different fmt versions #1117

wants to merge 1 commit into from

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Jun 29, 2023

Allow building against different fmt versions. Very useful for GNU/Linux.

@BillyONeal
Copy link
Member

This is broken because you've tried to include a header in its fwd header.

Can you provide a meaningful justification for this? We aren't supporting any configuration that isn't the one that CMakeLists is going to give you.

@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 4, 2023

This is broken because you've tried to include a header in its fwd header.

Everything builds as expected. All tests passed.

Can you provide a meaningful justification for this? We aren't supporting any configuration that isn't the one that CMakeLists is going to give you.

Some GNU/Linux distributions (Fedora Linux for example) have vcpkg in their repositories and we need to be able to build vcpkg against different fmt versions (currently we only have fmt 10 in unreleased development branch).

@BillyONeal
Copy link
Member

Some GNU/Linux distributions (Fedora Linux for example) have vcpkg in their repositories and we need to be able to build vcpkg against different fmt versions (currently we only have fmt 10 in unreleased development branch).

How do you get the rest of the supporting files vcpkg needs to be reasonable?

@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 11, 2023

How do you get the rest of the supporting files vcpkg needs to be reasonable?

All other sources are okay and can be built with fmt 8.0 - 10. The problem is the use of the inline namespace fmt::vX in include/vcpkg/base/fwd/format.h.

Maybe it can be rewritten with using a custom formatter without changing fmt's namespace?

@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 17, 2023

@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 27, 2023

microsoft/vcpkg#32784

@xvitaly xvitaly closed this by deleting the head repository Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants