Change max_port_file_count to warn rather than failing to calculate an ABI hash. #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierMatosD
approved these changes
Jun 21, 2023
|
The reason for this max file count was to avoid appearing to "hang" if users accidentally cloned source repos into the port directory. We will recurse into .git directories and attempt to hash tens or hundreds of thousands of files. Would it be more appropriate to raise this limit to 1,000 instead of removing it entirely? |
I think we should address this with a warning rather than just refusing to calculate the correct cache information. I'll restore the limit but make it trigger a warning rather than refusing to generate a cache entry. |
BillyONeal
changed the title
ras0219-msft
approved these changes
Jul 7, 2023
| HashPortManyFiles, | ||
| (msg::package_name, msg::count), | ||
| "", | ||
| "The {package_name} contains a {count} files. Hashing these contents may take a long time when determining the ABI " |
There was a problem hiding this comment.
Suggested change
| "The {package_name} contains a {count} files. Hashing these contents may take a long time when determining the ABI " | |
| "The {package_name} contains {count} files. Hashing these contents may take a long time when determining the ABI " |
| (msg::package_name, msg::count), | ||
| "", | ||
| "The {package_name} contains a {count} files. Hashing these contents may take a long time when determining the ABI " | ||
| "hash for binary caching. You should probably consider reducing the number of files. Common causes of this are " |
There was a problem hiding this comment.
Suggested change
| "hash for binary caching. You should probably consider reducing the number of files. Common causes of this are " | |
| "hash for binary caching. Consider reducing the number of files. Common causes of this are " |
| "", | ||
| "The {package_name} contains a {count} files. Hashing these contents may take a long time when determining the ABI " | ||
| "hash for binary caching. You should probably consider reducing the number of files. Common causes of this are " | ||
| "accidentally checking out source or build trees into a port's directory.") |
There was a problem hiding this comment.
Suggested change
| "accidentally checking out source or build trees into a port's directory.") | |
| "accidentally checking out source or build files into a port's directory.") |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jul 7, 2023
I missed CR comments in microsoft#1104
BillyONeal
added a commit
that referenced
this pull request
Jul 7, 2023
I missed CR comments in #1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves microsoft/vcpkg#31975 .