ToolCache: Better explain errors. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures look legitimate, so I'm drafting this for now. |
autoantwort
force-pushed
the
feature/tool-cache-better-errors
branch
from
3ab1e37
to
f767c57
Compare
vicroms
approved these changes
Jun 19, 2023
BillyONeal
requested changes
Jun 21, 2023
src/vcpkg/tools.cpp
Outdated
| Optional<PathAndVersion> find_first_with_sufficient_version(MessageSink& status_sink, | ||
| const ToolProvider& tool_provider, | ||
| const std::vector<Path>& candidates, | ||
| Func&& accept_version) const | ||
| Func&& accept_version, | ||
| Func2&& log_candidate) const |
There was a problem hiding this comment.
This should not be &&, because if it is an rvalue, calling it might 'destroy' it.
Yes I know the other one is already wrong.
It should get a comment describing the call interface.
BillyONeal
approved these changes
Jul 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vcpkg#31292 and microsoft/vcpkg#26377