Fail with proper message if you use upgrade in manifest mode.

[autoantwort]

Currently you get:

➜  vcpkg git:(master) vcpkg upgrade --no-dry-run test
error: The upgrade command does not currently support manifest mode. Instead, modify your vcpkg.json and run install.
/Users/leanderSchulten/git_projekte/vcpkg-tool/src/vcpkg/commands.upgrade.cpp(49): unreachable code was reached

Which is imo not the optimal message to be shown to the user.

In the past msg_exit_maybe_upgrade was used, but since I don't expect that upgrade will ever work in manifest mode I decided to use msg_exit_with_error.

Now:

➜  vcpkg git:(master) vcpkg upgrade --no-dry-run test
error: The upgrade command does not currently support manifest mode. Instead, modify your vcpkg.json and run install.

[Neumann-A]

Shouldn't upgrade in manifest mode not actually redirect to normal install in manifest mode? I mean manifest mode autoupdates the installed tree any way.

[BillyONeal]

Shouldn't upgrade in manifest mode not actually redirect to normal install in manifest mode? I mean manifest mode autoupdates the installed tree any way.

We could redirect to x-update-manifest when the experimental tag comes off of that, but I don't think upgrade should do that.

[BillyONeal]

Thanks!