Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_real_filesystem() into a variable rather than a function. #1051

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented May 3, 2023

Change get_real_filesystem() into a variable rather than a function.

Also:

  • Make all the things const so that the overall variable can be constexpr.
  • Implement the readonlyness with a drived interface type rather than cv qualifiers, as requested by @ras0219-msft.

src/vcpkg/base/files.cpp Outdated Show resolved Hide resolved
@BillyONeal BillyONeal changed the title defunction get_real_filesystem() Change get_real_filesystem() into a variable rather than a function. May 9, 2023
Also:

* Make all the things const so that the overall variable can be constexpr.
* Implement the readonlyness with a drived interface type rather than cv qualifiers, as requested by @ras0219-msft.
@BillyONeal BillyONeal force-pushed the defunction-get-real-filesystem branch from 2a1dada to 8bd0e3c Compare May 9, 2023 20:35
@BillyONeal BillyONeal marked this pull request as ready for review May 9, 2023 20:35
…ilesystem

# Conflicts:
#	include/vcpkg/archives.h
#	include/vcpkg/binarycaching.h
#	src/vcpkg-test/binarycaching.cpp
#	src/vcpkg/archives.cpp
#	src/vcpkg/binarycaching.cpp
…ilesystem

# Conflicts:
#	src/vcpkg/postbuildlint.cpp
@BillyONeal BillyONeal merged commit 3db1ef6 into microsoft:main Jun 12, 2023
@BillyONeal BillyONeal deleted the defunction-get-real-filesystem branch June 12, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants