Add new package for loading tsdoc-config.json file #196
Conversation
…aining package.json
octogonz
force-pushed
the
octogonz/tsdoc-config
branch
from
5aea91f
to
d89d2c5
Compare
| @@ -0,0 +1,59 @@ | |||
| { | |||
| "name": "@microsoft/tsdoc-config", | |||
| "version": "0.12.15", | |||
There was a problem hiding this comment.
This is a weird version. Is this package expected to stay in lockstep with the tsdoc package?
There was a problem hiding this comment.
I think that would be best, but I'll set up the version policy in a separate PR, since it may alter the CI scripts.
| @@ -0,0 +1,2 @@ | |||
| registry=https://registry.npmjs.org/ | |||
There was a problem hiding this comment.
This was just copied from the other projects in the repo. Probably they should all be removed. But let's deal with that in a separate PR.
| private static _findConfigPathForFolder(folderPath: string): string { | ||
| if (folderPath) { | ||
| let foundFolder: string = folderPath; | ||
| for (;;) { |
There was a problem hiding this comment.
Infinite loops are the One True Loop Style! (1TLS) do/while are degenerate special cases. 😊
| @@ -0,0 +1,36 @@ | |||
| { | |||
There was a problem hiding this comment.
You don't want to pull RSC into this repo?
There was a problem hiding this comment.
It's been useful to have a counterexample of a minimalist toolchain. I'd consider heft, though.
Initial sketch of the tsdoc-config.json feature proposed in RFC #7.
Because the loader relies on NodeJS libraries as well as
resolveandajv, I put this code in a separate NPM package@microsoft/tsdoc-config. That way@microsoft/tsdoccan remain fully self-contained and portable.@ecraig12345