Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default terminal item from SUI #9671

Merged
2 commits merged into from
Mar 31, 2021
Merged

Remove default terminal item from SUI #9671

2 commits merged into from
Mar 31, 2021

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Mar 31, 2021

Looks like we forgot to comment out the Default terminal setting from the UI.

Commented it out here.

@zadjii-msft
Copy link
Member

You gotta run runxamlformat now to format XAML files 😉

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just format it!

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOMEONE promised me that x:Load="False" was good enough here. :|

@zadjii-msft
Copy link
Member

SOMEONE promised me that x:Load="False" was good enough here. :|

Wait it totally should have been. Why isn't it?

@DHowett
Copy link
Member

DHowett commented Mar 31, 2021

Yeah, I totally don't understand why it wasn't sufficient. Are we calling FindElement on it? o_O

@DHowett
Copy link
Member

DHowett commented Mar 31, 2021

OH. It's inside a SettingContainer. The setting container loads it immediately because it is a data template(!). If the x:Load was on the SettingContainer, the whole element would be kill.

@miniksa
Copy link
Member

miniksa commented Mar 31, 2021

OH. It's inside a SettingContainer. The setting container loads it immediately because it is a data template(!). If the x:Load was on the SettingContainer, the whole element would be kill.

DERP. Sorry.

@DHowett
Copy link
Member

DHowett commented Mar 31, 2021

@msftbot merge this in 2 minutes ago

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 31, 2021
@ghost
Copy link

ghost commented Mar 31, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 31 Mar 2021 18:37:15 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit fd99b01 into main Mar 31, 2021
@ghost ghost deleted the cinnamon-msft-patch-2 branch March 31, 2021 18:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants