-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Base Layer from Settings UI #9655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. We can revert this or look at the original code when we want to bring it back. Which we will.
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
I am glad that this will conflict with 1.7 because of the xaml reformatting -.- |
Removes base layer (aka profiles.defaults) from the Settings UI. `SettingContainer` was also updated to not present a revert arrow when overriding a base layer value. The new experience is now as follows: - The revert arrow will only appear if you are overriding a value from a fragment extension. - Users are still able to fully interact with `profiles.defaults` in their settings.json. Doing so still propagates those changes to their profiles as normal. In this case, the Settings UI presents the base layer value as the one that you selected. Closes #9539 (cherry picked from commit 19fb9b2)
🎉 Handy links: |
🎉 Handy links: |
Removes base layer (aka profiles.defaults) from the Settings UI.
SettingContainer
was also updated to not present a revert arrow when overriding a base layer value.The new experience is now as follows:
profiles.defaults
in their settings.json. Doing so still propagates those changes to their profiles as normal. In this case, the Settings UI presents the base layer value as the one that you selected.#6800 - Settings UI Epic
Closes #9539