Add a --colorScheme param to new-tab, split-pane
#9602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Product-Terminal
This comment has been minimized.
This comment has been minimized.
zadjii-msft
added a commit
to MicrosoftDocs/terminal
that referenced
this pull request
Mar 24, 2021
carlos-zamora
approved these changes
Mar 25, 2021
WSLUser
reviewed
Mar 26, 2021
| @@ -66,6 +66,10 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation | |||
| const til::color tabColor{ _TabColor.Value() }; | |||
| ss << fmt::format(L"tabColor: {}, ", tabColor.ToHexString(true)); | |||
| } | |||
| if (!_ColorScheme.empty()) | |||
| { | |||
| ss << fmt::format(L"colorScheme: {}, ", _ColorScheme); | |||
There was a problem hiding this comment.
Might it make sense to use FMT_COMPILE here (and the one below) instead similar to #9581 or would it make more sense to do all the params at once in a separate PR?
There was a problem hiding this comment.
Probably makes sense to do them all in a single pass IMO
ghost
requested review from
DHowett
reviewed
Mar 29, 2021
DHowett
approved these changes
Mar 29, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
approved these changes
Mar 29, 2021
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely self-serving. In my go-to config, I like having some of
the panes for a given profile in a different color scheme. This will let
a user pass
--colorScheme <scheme name>to manually override thescheme for that profile. Neat!