Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate the shell extension CLSIDs to allow usage SXS #9510

Merged
2 commits merged into from
Mar 17, 2021
Merged

Disambiguate the shell extension CLSIDs to allow usage SXS #9510

2 commits merged into from
Mar 17, 2021

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 15, 2021

Fixes #6416

@ghost ghost added Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 15, 2021
zadjii-msft
zadjii-msft approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the pr body?

@DHowett
Copy link
Member Author

DHowett commented Mar 15, 2021

Is there something that belongs in the PR body? I've signed the CLA, this fixes an issue, there are no more details, there's no docs. 😄

@zadjii-msft
Copy link
Member

yea okay, this is a good case where there's nothing else needed. Just feels weird 😝

@DHowett
Copy link
Member Author

DHowett commented Mar 15, 2021

Well hey, I should not be above the rules. I'm adding some info about validation.

@DHowett
Copy link
Member Author

DHowett commented Mar 15, 2021

@zadjii-msft it's only a 3-line diff to add it to drive roots and fix #6654 at the same time. 😄

I may rollup.

@DHowett
Copy link
Member Author

DHowett commented Mar 15, 2021 •
edited
Loading

Nevermind, the platform doesn't support it.

zadjii-msft
zadjii-msft requested changes Mar 16, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 16, 2021
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 17, 2021
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Mar 17, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 17, 2021
@ghost
Copy link

ghost commented Mar 17, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1519236 into main Mar 17, 2021
@ghost ghost deleted the dev/duhowett/why_not_have_three_guids_instead_of_one branch March 17, 2021 20:32
@DHowett DHowett added zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. and removed zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Mar 17, 2021
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Apr 2, 2021
DHowett added a commit that referenced this pull request Apr 2, 2021
@DHowett
Disambiguate the shell extension CLSIDs to allow usage SXS (#9510)
396a698 
Fixes #6416

(cherry picked from commit 1519236)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal v1.7.1033.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 14, 2021
Closed
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett mentioned this pull request Apr 14, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-ShellExtension For issues related to the explorer right-click context menu AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Open Terminal Here" can't be used with both the dev build and preview at the same time
3 participants
@DHowett @zadjii-msft @carlos-zamora