Allow shift+click on a profile to open a new window

[PankajBhojwani]

Summary of the Pull Request

Shift+click on a profile to open a new wt window with that profile. Or, shift+click on the '+' button to open a new wt window with the default profile.

PR Checklist

• Closes Shift+Click on a profile opens a new window #9395
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I work here

Validation Steps Performed

Manual testing

[Nacimota]

I wonder if the tooltip/s should be updated as well, or would that be making them too wordy?

[Don-Vito]

I wonder if the tooltip/s should be updated as well, or would that be making them too wordy?

I agree with @Nacimota, since we already mention alt+click in tooltip we should probably mention shift+click as well.
Given we put it in a separate line of the tooltip, I believe it is not too wordy.

Alternatively, we could probably show different tooltips given the modifier (but I am not even sure what is the best way to implement such behavior).

[Nacimota]

Alternatively, we could probably show different tooltips given the modifier (but I am not even sure what is the best way to implement such behavior).

You mean instead of the current tip it would say "Split the current window" when you hold alt, for example? There is something about that which I find appealing, but I can't help but think it takes away from the discoverability a little bit, which I think is really what the tooltip is all about.

I've just tried it with both tips on separate lines as you suggested and I agree that it does not look too bad. I do worry that one can put too much text in there, though.

[Don-Vito]

Alternatively, we could probably show different tooltips given the modifier (but I am not even sure what is the best way to implement such behavior).

You mean instead of the current tip it would say "Split the current window" when you hold alt, for example? There is something about that which I find appealing, but I can't help but think it takes away from the discoverability a little bit, which I think is really what the tooltip is all about.

I agree that it somewhat reduces the value of the tool tip - it was just a fallback if we believe that the tool tip is too cluttered.

Somewhere in a separate thread we discussed alternatives for providing this information not via tool-tip but through some visible element / another organization of the menu.

[zadjii-msft]

This code looks fine, but I suppose I should block over the tooltip text

[PankajBhojwani]

Tooltip updated! Thanks for the feedback everyone

[ghost]

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download