Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TermControl initialization to pre-seed working dir #9397

Merged
2 commits merged into from
Mar 8, 2021
Merged

Fix TermControl initialization to pre-seed working dir #9397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced4381
Fix TermControl initialization to pre-seed working dir
Don-Vito Mar 5, 2021
cfed93d
Move the working directory initialization to the very beginning
Don-Vito Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/cascadia/TerminalControl/TermControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation

_terminal = std::make_unique<::Microsoft::Terminal::Core::Terminal>();

// GH#8969: pre-seed working directory to prevent potential races
_terminal->SetWorkingDirectory(_settings.StartingDirectory());

auto pfnWarningBell = std::bind(&TermControl::_TerminalWarningBell, this);
_terminal->SetWarningBellCallback(pfnWarningBell);

Expand Down