Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the newWindow action #9208

Merged
105 commits merged into from
Feb 19, 2021
Merged

Add support for the newWindow action #9208

105 commits merged into from
Feb 19, 2021

Commits on Dec 16, 2020

  1. Configuration menu
    Copy the full SHA
    3bef7bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f52d35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a9cdc8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    36539cf View commit details
    Browse the repository at this point in the history
  5. 1 Configuration menu
    Copy the full SHA
    27ace16 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. HOLY SHIT I GOT THE COMANDLINE TO EXECUTE IN THE CURRENT WINDOW!!!!!!…

    …!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    zadjii-msft committed Dec 17, 2020
    3 Configuration menu
    Copy the full SHA
    9a41647 View commit details
    Browse the repository at this point in the history
  2. add a note to future me

    zadjii-msft committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    5cabcfb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    03bfc6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    590b9ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0579b24 View commit details
    Browse the repository at this point in the history
  6. finish renaming this test

    zadjii-msft committed Dec 17, 2020
    1 Configuration menu
    Copy the full SHA
    a3faed6 View commit details
    Browse the repository at this point in the history
  7. Clean up a lot for review

    zadjii-msft committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9c6eac4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0103331 View commit details
    Browse the repository at this point in the history
  9. Final cleanup for review

    zadjii-msft committed Dec 17, 2020
    1 Configuration menu
    Copy the full SHA
    b4fe1bf View commit details
    Browse the repository at this point in the history
  10. 1 Configuration menu
    Copy the full SHA
    d08e65c View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. pr nits

    zadjii-msft committed Dec 18, 2020
    1 Configuration menu
    Copy the full SHA
    e101efd View commit details
    Browse the repository at this point in the history
  2. This seems to work to create a thread listening for the monarch, and …

    …safely tear it down. It _seems_ like it.
    zadjii-msft committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e1402d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f978a9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5939636 View commit details
    Browse the repository at this point in the history
  5. 1 Configuration menu
    Copy the full SHA
    c088895 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Configuration menu
    Copy the full SHA
    fa2df47 View commit details
    Browse the repository at this point in the history
  2. Enable audit mode

    zadjii-msft committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0f5c24f View commit details
    Browse the repository at this point in the history
  3. nits

    zadjii-msft committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    921d915 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00184e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Ask the TerminalApp to parse the commandline, and tell us what the wi…

    …ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.
    zadjii-msft committed Jan 6, 2021
    1 Configuration menu
    Copy the full SHA
    658db6b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    977db46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bcbef34 View commit details
    Browse the repository at this point in the history
  4. notes, comments, cleanup

    zadjii-msft committed Jan 6, 2021
    1 Configuration menu
    Copy the full SHA
    813dbc6 View commit details
    Browse the repository at this point in the history
  5. activate windows

    zadjii-msft committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0f0df5e View commit details
    Browse the repository at this point in the history
  6. add some tracelogging

    zadjii-msft committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9fc2f0e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Configuration menu
    Copy the full SHA
    6537686 View commit details
    Browse the repository at this point in the history
  2. mostly just notes

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a75da0a View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    c02f25a View commit details
    Browse the repository at this point in the history
  4. more comments

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    3e39ab9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52b2cb6 View commit details
    Browse the repository at this point in the history
  6. Code cleanup

    zadjii-msft committed Jan 7, 2021
    1 Configuration menu
    Copy the full SHA
    bc492f1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    88ffc6f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    be74b2e View commit details
    Browse the repository at this point in the history
  9. branding

    zadjii-msft committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2a7bc94 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Configuration menu
    Copy the full SHA
    81c09d9 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main' into dev/migrie/f/the-firs…

    …t-galactic-empire
    
    # Conflicts:
    #	OpenConsole.sln
    #	src/cascadia/Remoting/Microsoft.Terminal.RemotingLib.vcxproj
    #	src/cascadia/Remoting/Monarch.cpp
    #	src/cascadia/Remoting/Monarch.h
    #	src/cascadia/Remoting/Monarch.idl
    #	src/cascadia/Remoting/Peasant.cpp
    #	src/cascadia/Remoting/Peasant.h
    #	src/cascadia/Remoting/Peasant.idl
    #	src/cascadia/Remoting/WindowManager.cpp
    #	src/cascadia/Remoting/WindowManager.h
    #	src/cascadia/Remoting/WindowManager.idl
    #	src/cascadia/Remoting/pch.h
    #	src/cascadia/TerminalApp/AppLogic.h
    #	src/cascadia/TerminalApp/AppLogic.idl
    #	src/cascadia/TerminalApp/TerminalPage.cpp
    #	src/cascadia/TerminalApp/TerminalPage.h
    #	src/cascadia/UnitTests_Remoting/RemotingTests.cpp
    #	src/cascadia/WindowsTerminal/AppHost.cpp
    #	src/cascadia/WindowsTerminal/AppHost.h
    #	src/cascadia/WindowsTerminal/main.cpp
    zadjii-msft committed Jan 8, 2021
    1 Configuration menu
    Copy the full SHA
    c34e4ce View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    5b8ace2 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    689c385 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. 1 Configuration menu
    Copy the full SHA
    59deca1 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    f02969b View commit details
    Browse the repository at this point in the history
  3. man I can't spel

    zadjii-msft committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    b2db317 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Configuration menu
    Copy the full SHA
    d2a3438 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    a65f341 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. add some abstracts

    zadjii-msft committed Jan 29, 2021
    1 Configuration menu
    Copy the full SHA
    faf4544 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
    zadjii-msft and carlos-zamora authored Jan 29, 2021
    1 Configuration menu
    Copy the full SHA
    19765b1 View commit details
    Browse the repository at this point in the history
  3. a ton of PR feedback

    zadjii-msft committed Jan 29, 2021
    1 Configuration menu
    Copy the full SHA
    4e007ae View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. bunch of PR feedback

    zadjii-msft committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    c493607 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    8de368a View commit details
    Browse the repository at this point in the history
  3. !!! THIS NEEDS TO BE MOVED TO THE PARENT BRANCH !!!

    (cherry picked from commit a41bee6)
    zadjii-msft committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    e6bd315 View commit details
    Browse the repository at this point in the history
  4. !!! THIS NEEDS TO BE MOVED TO THE PARENT BRANCH !!!

    (cherry picked from commit 6e7ea61)
    zadjii-msft committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    a62d53f View commit details
    Browse the repository at this point in the history
  5. !!! THIS NEEDS TO BE MOVED TO THE PARENT BRANCH !!!

      > The **low-order word** specifies whether the window is being activated or deactivated.
    
    (cherry picked from commit 91b52d4)
    zadjii-msft committed Feb 2, 2021
    1 Configuration menu
    Copy the full SHA
    147b187 View commit details
    Browse the repository at this point in the history
  6. bad merge

    zadjii-msft committed Feb 2, 2021
    1 Configuration menu
    Copy the full SHA
    a102f44 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7097274 View commit details
    Browse the repository at this point in the history
  8. barf I hate the stl

    zadjii-msft committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    67b525b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e4357c5 View commit details
    Browse the repository at this point in the history
  10. 1 Configuration menu
    Copy the full SHA
    e0d5a84 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Configuration menu
    Copy the full SHA
    32ebf4e View commit details
    Browse the repository at this point in the history
  2. Start working on tests

    zadjii-msft committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    9ab951c View commit details
    Browse the repository at this point in the history
  3. What? No yea I always run the tests

    (cherry picked from commit 2367db1)
    zadjii-msft committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    6dc0feb View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    9e94b36 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Configuration menu
    Copy the full SHA
    39c4e44 View commit details
    Browse the repository at this point in the history
  2. !!! This needs to go to the parent branch !!!

      Turns out, I did _NOT_ do my diligence try/catching this as needed. This is all going to be really bad.
    
    (cherry picked from commit 26815e8)
    zadjii-msft committed Feb 9, 2021
    1 Configuration menu
    Copy the full SHA
    031139b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Configuration menu
    Copy the full SHA
    26437b0 View commit details
    Browse the repository at this point in the history
  2. Fix a weird bug in windowingBehavior:useExisting

      Repro steps were:
      * use windowingBehavior:useExisting
      * Create two windows
      * close the second one, but make sure that focus falls onto another app (not
        the first wt window)
      * switch to a second desktop
      * run `wt`.
    
      That _should_ still create a tab in the first window, on the other desktop.
      The issue was though,t hat we'd agree that window 2 was the MRU one, and try
      to get it to execute the commandline. That would fail, and we'd fall back to
      "make a new window".
    zadjii-msft committed Feb 10, 2021
    1 Configuration menu
    Copy the full SHA
    683c146 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8072efa View commit details
    Browse the repository at this point in the history
  4. revert this file

      This got polluted here from another branch
    zadjii-msft committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5edfe28 View commit details
    Browse the repository at this point in the history
  5. Some spellcheck fixes

    zadjii-msft committed Feb 10, 2021
    1 Configuration menu
    Copy the full SHA
    ccf8d63 View commit details
    Browse the repository at this point in the history
  6. it'd be a shame if I wrote unittests for a data structure that I need…

    … to get rid of entirely
    zadjii-msft committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5abb55a View commit details
    Browse the repository at this point in the history
  7. this is a disaster

    zadjii-msft committed Feb 10, 2021
    1 Configuration menu
    Copy the full SHA
    8537a2d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Configuration menu
    Copy the full SHA
    5315779 View commit details
    Browse the repository at this point in the history
  2. fix the tests

    zadjii-msft committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    f9445d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5df4c16 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8aefb6c View commit details
    Browse the repository at this point in the history
  5. Revert "Somehow, this breaks the world? I'm just going to revert all …

    …of it"
    
    This reverts commit 8aefb6c.
    zadjii-msft committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    8d05c5d View commit details
    Browse the repository at this point in the history
  6. ho boy am I daft

    zadjii-msft committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    36bb19b View commit details
    Browse the repository at this point in the history
  7. Ready for the prime time

    zadjii-msft committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    f96dad4 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Configuration menu
    Copy the full SHA
    4860066 View commit details
    Browse the repository at this point in the history
  2. HA this finally works

    zadjii-msft committed Feb 12, 2021
    1 Configuration menu
    Copy the full SHA
    3cbaa26 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. A bunch of test fixes

    zadjii-msft committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    ccda434 View commit details
    Browse the repository at this point in the history
  2. More test fixes I missed

    zadjii-msft committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    994a6a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdcb6fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00a4093 View commit details
    Browse the repository at this point in the history
  5. Rename the setting

    zadjii-msft committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    e15c345 View commit details
    Browse the repository at this point in the history
  6. Add windowingBehavior to the SUI

      @carlos-zamora why the heck doesn't this work? It works to change the value of the setting, but it does _not_ work on the initial load of the Launch page. It always selects UseNew. But if I change the value, DONT SAVE, navigate away from the page, then back to the page, then it loads correctly. What gives?
    zadjii-msft committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    570375d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    8c524e4 View commit details
    Browse the repository at this point in the history
  2. most of the PR feedback

    zadjii-msft committed Feb 18, 2021
    1 Configuration menu
    Copy the full SHA
    257d92b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bf6754 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1c6d5a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e5c7d9 View commit details
    Browse the repository at this point in the history
  6. minor comments updates

    zadjii-msft committed Feb 18, 2021
    1 Configuration menu
    Copy the full SHA
    6e0441f View commit details
    Browse the repository at this point in the history
  7. dead code removal

    zadjii-msft committed Feb 18, 2021
    1 Configuration menu
    Copy the full SHA
    5867325 View commit details
    Browse the repository at this point in the history
  8. some PR nits

    zadjii-msft committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    cb311d8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5eff079 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d18827a View commit details
    Browse the repository at this point in the history
  11. spellbot

    zadjii-msft committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    c62a86c View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. words r hard

    zadjii-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    fa96b5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eca3125 View commit details
    Browse the repository at this point in the history
  3. Add to the schema too

    zadjii-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    14f027c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a34f6be View commit details
    Browse the repository at this point in the history
  5. This was the only thing Dustin was blocking on

      it's now _after_ 5pm on a friday so I'm not doing the rest
    zadjii-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    34e0d0c View commit details
    Browse the repository at this point in the history