Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltips and setting names in SUI #8777

Merged
7 commits merged into from
Jan 19, 2021
Merged

Update tooltips and setting names in SUI #8777

7 commits merged into from
Jan 19, 2021

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Jan 13, 2021 •
edited by DHowett
Loading

Change wording for some settings and tooltips to make them clearer.

Closes #8746

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jan 13, 2021
carlos-zamora
carlos-zamora approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for doing this! I know it's a bit tedious.

src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw Outdated Show resolved Hide resolved
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jan 15, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 18, 2021
@ghost
Copy link

ghost commented Jan 18, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6c4878c into main Jan 19, 2021
@ghost ghost deleted the cinnamon/tooltip-polish branch January 19, 2021 12:14
This was referenced Jan 21, 2021
Closed
Open
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@cinnamon-msft @mpela81
Update tooltips and setting names in SUI (microsoft#8777)
f186cdd 
Change wording for some settings and tooltips to make them clearer.

Closes microsoft#8746
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalize localization changes for Settings UI
3 participants
@cinnamon-msft @DHowett @carlos-zamora