Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SetCursorColor in Terminal #7123

Merged
1 commit merged into from
Jul 30, 2020
Merged

Implement SetCursorColor in Terminal #7123

1 commit merged into from
Jul 30, 2020

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 30, 2020 •
edited by DHowett
Loading

This was never hooked up to the TerminalCore implementation.

Closes #7102

@ghost ghost added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jul 30, 2020
@ghost
Copy link

ghost commented Jul 30, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

miniksa
miniksa reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing something here... this is the handler for the color setting in the terminal and the interface... but where's the dispatch? Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

@PankajBhojwani
Copy link
Contributor Author

I'm missing something here... this is the handler for the color setting in the terminal and the interface... but where's the dispatch? Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

I believe so - ITermDispatch.hpp has a list of VT sequence declarations but many of them (including SetCursorColor before this PR goes through) don't have implementations anywhere.

@zadjii-msft
Copy link
Member

Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

YUP

@miniksa
Copy link
Member

miniksa commented Jul 30, 2020

Was it already implemented and the default from the VT parser/adapter nullrouted it to do nothing and return true?

YUP

WELP. OKAY THEN.

@miniksa miniksa changed the title Implements SetCursorColor Implement SetCursorColor in Terminal Jul 30, 2020
@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 30, 2020
@ghost
Copy link

ghost commented Jul 30, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 4 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this rocks

@ghost ghost merged commit 2f5ba94 into master Jul 30, 2020
@ghost ghost deleted the dev/pabhoj/cursor_color branch July 30, 2020 22:25
DHowett pushed a commit that referenced this pull request Jul 31, 2020
@PankajBhojwani @DHowett
Implement SetCursorColor in Terminal (#7123)
288436a 
This was never hooked up to the TerminalCore implementation.

Closes #7102

(cherry picked from commit 2f5ba94)
@ghost
Copy link

ghost commented Aug 13, 2020

🎉Windows Terminal Preview v1.2.2234.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 13, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSC 12 cursor colour update doesn't appear to be working
4 participants
@PankajBhojwani @zadjii-msft @miniksa @DHowett