Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the legacy color conversions #6358

Merged
10 commits merged into from
Jun 8, 2020
Merged

Improve the legacy color conversions #6358

10 commits merged into from
Jun 8, 2020

Commits on Jun 6, 2020

  1. Eliminate unnecessary GetLegacyAttribute calls in the console IME.

    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    b405a87 View commit details
    Browse the repository at this point in the history

  2. Eliminate unnecessary GetLegacyAttribute use in the color selection h… 

    …andler.
    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    65155b7 View commit details
    Browse the repository at this point in the history

  3. Eliminate unnecessary color remapping in the popup windows.

    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    a18dc5e View commit details
    Browse the repository at this point in the history

  4. Why are popup attributes returned as a pointer?

    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    a4d5aea View commit details
    Browse the repository at this point in the history

  5. Simplify the null fill hack in ScrollRegion to avoid using GetLegacyA… 

    …ttributes.
    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    b315b7e View commit details
    Browse the repository at this point in the history

  6. Update ReadOutputAttributes to use the more correct GenerateLegacyAtt… 

    …ributes method.
    @j4james
    j4james committed Jun 6, 2020
    Configuration menu
    Copy the full SHA
    9a2174e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Reimplement the legacy attribute generation with simple table lookups.

    @j4james
    j4james committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    e1864e8 View commit details
    Browse the repository at this point in the history

  2. Get rid of unused TextAttribute methods.

    @j4james
    j4james committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    f8b1479 View commit details
    Browse the repository at this point in the history

  3. Add RRRGGGBB to spell-check whitelist.

    @j4james
    j4james committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    dbc66b4 View commit details
    Browse the repository at this point in the history

  4. Update the legacy color feature test to account for the different val… 

    …ues returned by the new algorithm.
    @j4james
    j4james committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    be5fd3f View commit details
    Browse the repository at this point in the history