Add and enforce minimum width

[carlos-zamora]

Summary of the Pull Request

Enforces a minimum width of 460 wide. This allows tabs to always be seen (albeit partially).

NOTE: A minimum height was originally added to allow the About menu to be seen. This minimum height was removed from this PR because we don't foresee a circumstance where your Terminal is in that state, and you can't just resize it to make the content fit properly.

References

#4990 may be fixed/affected by this?

PR Checklist

• Closes Minimize button disappears at minimum size #4976
• Will close issue A11y_Windows Terminal_Windows PowerShell_Reflow: When reflow is performed, user is not able to view complete Tab name #5418 upon verification

Validation Steps Performed

Here's some images of what the terminal looks like when it's at its minimum size:

100% scaling

100% scaling: one tab

100% scaling: two tabs

100% scaling: 3 tabs (scrolling enabled)

200% scaling

200% scaling: one tab

200% scaling: two tabs

200% scaling: 3 tabs (scrolling enabled)

[DHowett-MSFT]

Please make sure this applies when snapToGridOnResize is false.

Please share a sample (screenshot?) of how big/small this minimum size is.

Maybe we should only enforce a minimum width.

[zadjii-msft]

I concur with:

• Please make sure this applies when snapToGridOnResize is false.
• Maybe we should only enforce a minimum width.
• Does this actually resolve Interesting Resizing behaviour #4990?

[DHowett-MSFT]

        template<typename TilMath>
        size scale(TilMath, const float scale) const
        {
            struct
            {
                float Width, Height;
            } sz;
            THROW_HR_IF(E_ABORT, !base::CheckMul(scale, _width).AssignIfValid(&sz.Width));
            THROW_HR_IF(E_ABORT, !base::CheckMul(scale, _height).AssignIfValid(&sz.Height));

            return til::size(TilMath(), sz);
        }

???????? definitely exists

sz.scale(til::math::rounding, 1.5f)

[carlos-zamora]

        template<typename TilMath>
        size scale(TilMath, const float scale) const
        {
            struct
            {
                float Width, Height;
            } sz;
            THROW_HR_IF(E_ABORT, !base::CheckMul(scale, _width).AssignIfValid(&sz.Width));
            THROW_HR_IF(E_ABORT, !base::CheckMul(scale, _height).AssignIfValid(&sz.Height));

            return til::size(TilMath(), sz);
        }

???????? definitely exists

sz.scale(til::math::rounding, 1.5f)

Yeah. Michael just gave me a walkthrough on it and being able to cast the output. I've been out of the loop for a while haha.

[carlos-zamora]

I concur with:

• Please make sure this applies when snapToGridOnResize is false.

Just verified it, works fine.

• Maybe we should only enforce a minimum width.

#5418 needs the width and height. Width ensures tabs can always be read. Height ensures about menu fits (see attached features above.

• Does this actually resolve Interesting Resizing behaviour #4990?

I can't actually get a repro on this one. But I can't get it on 0.11 either. @DHowett-MSFT or @zadjii-msft, if either of you can actually get a repro on this, would you mind checking it? Mainly just tagged it because there's a comment that enforcing a minimum size might help.

[carlos-zamora]

Here's an idea of how big the minimum size is:

[DHowett-MSFT]

This is too tall. people will hate it.

[DHowett-MSFT]

Some people legitimately want a one-line-tall terminal. Let's not optimize around an ephemeral dialog.

[carlos-zamora]

I hate it too :/ But how else can we get the About menu to fit?

[zadjii-msft]

Can we do this for now, and add a minimum size setting in 2.0?

[DHowett-MSFT]

I'm a hard NAK on the height. Width is fine. Min height = tab strip height. Let people make their about dialogs disappear.

[carlos-zamora]

Updated the PR to only enforce the minimum width.

[zadjii-msft]

Nice, thanks for checking those things!

[DHowett-MSFT]

Thanks

[ghost]

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1) has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download