Add a Third-Party notices link to the about dialog #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
approved these changes
Apr 23, 2020
ghost
added
the
Needs-Author-Feedback
DHowett-MSFT
suggested changes
Apr 23, 2020
There was a problem hiding this comment.
I love this. Just a couple concerns.
- Will this fail in a catastrophic way if we're ever caught out outside of our git repo
- Will this work for worktrees
- Are there any incremental build concerns? If I hit F5, will it cause a rebuild of TerminalApp because this header file changed?
- If so, we can probably fix it by having an
OutputFilesor something on the MSBuild task so it can detect that it's not up-to-date - If we need to have an InputFiles to compensate for that, we could point it at the notices.md file directly
- If so, we can probably fix it by having an
zadjii-msft
added
Area-Build
|
Skipping review. 3 cooks in this kitchen already. |
ghost
removed
the
Needs-Author-Feedback
leonMSFT
added
the
AutoMerge
|
Hello @leonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR will add a link to the version of
NOTICE.mdin GitHub at the commit that the build was on. It uses the same approach for generating our settings files, where we'll create a header file with the commit hash assigned to awstring_viewduring build time.PR Checklist
Validation Steps Performed
The link is there and goes to the expected
NOTICE.md.