Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying the version with wt --version #5501

Merged
3 commits merged into from
May 4, 2020
Merged

Add support for displaying the version with wt --version #5501

3 commits merged into from
May 4, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Here's 3000 words:

image
image
image

References

PR Checklist

@zadjii-msft zadjii-msft added Area-Commandline wt.exe's commandline arguments Product-Terminal The new Windows Terminal. labels Apr 23, 2020
DHowett-MSFT
DHowett-MSFT reviewed Apr 23, 2020
View reviewed changes
src/cascadia/TerminalApp/AppCommandlineArgs.cpp
if (const auto appLogic{ winrt::TerminalApp::implementation::AppLogic::Current() })
{
// Set our message to display the application name and the current version.
_exitMessage = fmt::format("{0}\n{1}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yyyyaaaasssss

DHowett-MSFT
DHowett-MSFT reviewed Apr 23, 2020
View reviewed changes
src/cascadia/WindowsTerminal/AppHost.cpp
@@ -115,7 +115,10 @@ void AppHost::_HandleCommandlineArgs()
GetStringResource(messageTitle).data(),
MB_OK | messageIcon);

ExitProcess(result);
if (_logic.ShouldExitEarly())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're still covered in the version case by the message being non-empty -- we could simplify this changeset more if there's no compelling reason to introduce ShoudlExitEarly up through the stack. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sure, we don't need it in this PR anymore. Originally I was only going to exit early if there were no subcommands specified after a --version.

Now, I'm thinking about using it in the future for open-settings - if there's no subcommands other than open-settings, just open the file and exit. I don't feel strongly about keeping it around for now, but I will probably be using it in the future so ¯\_(ツ)_/¯

DHowett-MSFT
DHowett-MSFT approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it as-is, but I am curious. 😄

miniksa
miniksa approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with keeping it to make the future easier. Looks good.

@WSLUser
Copy link
Contributor

WSLUser commented Apr 27, 2020 •
edited
Loading

@zadjii-msft Can we merge this in? If it's got enough approvals, we should get this in for v1.

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 4, 2020
@ghost
Copy link

ghost commented May 4, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6ce3357 into master May 4, 2020
@ghost ghost deleted the dev/migrie/b/5494--version branch May 4, 2020 20:56
@ghost
Copy link

ghost commented Jun 18, 2020 •
edited by miniksa
Loading

🎉Windows Terminal Preview v1.1.1671.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 18, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Area-Commandline wt.exe's commandline arguments AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear how to determine installed version?
4 participants
@zadjii-msft @WSLUser @DHowett-MSFT @miniksa