Convert TermControl to .xaml #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes all of the custom UI initialization code in TermControl and replaces it with a xaml file. Some dead or reundant code was removed as part of this refactoring. It also fixes two (quasi-related) issues: * The search box, on first launch, was offset by the scrollbar even if the scrollbar was invisible. * The scrollbar state wasn't hot-reloadable.
|
To be considered: All of the getters ( |
|
This broke Background color (!) |
|
The xaml compiler automatically generates weak event handlers for every event we subscribe to using xaml. It automatically connects the local members of the TermControl to the Names specified in the xaml file. It even emitted Unload handlers for the search box control because I made it dynamically loadable. |
carlos-zamora
approved these changes
Feb 26, 2020
leonMSFT
approved these changes
Feb 27, 2020
ghost
pushed a commit
that referenced
this pull request
Feb 28, 2020
This pull request is like #4729 but for TSFInputControl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all of the custom UI initialization code in
TermControl and replaces it with a xaml file. Some dead or reundant code
was removed as part of this refactoring.
It also fixes two (quasi-related) issues:
the scrollbar was invisible.
PR Checklist
Validation Steps Performed
Launched, opened, closed, searched and TSF-inputted-into controls.
Fixes #4920