Add a warning when a profile has an unknown color scheme #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-Settings
DHowett-MSFT
suggested changes
Oct 2, 2019
ghost
added
Needs-Author-Feedback
DHowett-MSFT
approved these changes
Oct 4, 2019
| @@ -590,13 +539,13 @@ ColorScheme* CascadiaSettings::_FindMatchingColorScheme(const Json::Value& schem | |||
| { | |||
| for (auto& scheme : _globals.GetColorSchemes()) | |||
There was a problem hiding this comment.
nit: file a followup here. now that we have a map, no need to iterate all of them. key=name=able to find layering scheme
ghost
requested review from
miniksa
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
I'm OK with this with Dustin's comments. @DHowett-MSFT since @zadjii-msft is out, do you want to fix your own nits so we can get this into 1910? Do you want me to fix them for him?
|
I'll do it and resolve the conflicts. |
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add a warning when the user sets their
colorSchemeto a scheme that doesn't exists. When that occurs, we'll set their color table to the campbell scheme, to prevent it from being just entirely black.PR Checklist