Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: TextBuffer Line Wrapping from VTRenderer #2797

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Bugfix: TextBuffer Line Wrapping from VTRenderer #2797

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7a8b9d
Bugfix: line selection copy
Sep 14, 2019
0c66896
Revert clipboard change
carlos-zamora Sep 17, 2019
0e25207
revert TerminalApi change
carlos-zamora Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/renderer/vt/paint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,22 @@ using namespace Microsoft::Console::Types;

if (useEraseChar)
{
RETURN_IF_FAILED(_EraseCharacter(sNumSpaces));
// ECH doesn't actually move the cursor itself. However, we think that
// the cursor *should* be at the end of the area we just erased. Stash
// that position as our new deferred position. If we don't move the
// cursor somewhere else before the end of the frame, we'll move the
// cursor to the deferred position at the end of the frame, or right
// before we need to print new text.
_deferredCursorPos = { _lastText.X + sNumSpaces, _lastText.Y };

if (_deferredCursorPos.X < _lastViewport.RightInclusive())
{
RETURN_IF_FAILED(_EraseCharacter(sNumSpaces));
}
else
{
RETURN_IF_FAILED(_EraseLine());
}
}
else if (_newBottomLine)
{
Expand Down