Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylus Selection Support #2586

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Aug 28, 2019

Summary of the Pull Request

You can now use the stylus to create a selection on your device.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Just added the device type to where we handle a mouse.

Validation Steps Performed

@cinnamon-msft: I dragged the stylus over text inside the Terminal and it selected cell-by-cell

@carlos-zamora carlos-zamora self-assigned this Aug 28, 2019
@cinnamon-msft
Copy link
Contributor

Works great!

@DHowett-MSFT
Copy link
Contributor

Do we want to make it so that pen input always selects, or do we want to check whether the user is holding down the pen selection button?
I wonder if we need to think more about how this should work.

@miniksa
Copy link
Member

miniksa commented Aug 29, 2019

Do we want to make it so that pen input always selects, or do we want to check whether the user is holding down the pen selection button?
I wonder if we need to think more about how this should work.

Pen doing always-selection and acting just like a mouse is how the conhost did it. I think it's a reasonable change to make until proven otherwise.

@carlos-zamora
Copy link
Member Author

Do we want to make it so that pen input always selects, or do we want to check whether the user is holding down the pen selection button?
I wonder if we need to think more about how this should work.

I think that would fall under #1553 (Pointer Bindings). That way, users can decide how they want the stylus to operate vs touching the screen vs using the mouse.

@carlos-zamora carlos-zamora merged commit 2ac2497 into master Sep 10, 2019
@carlos-zamora carlos-zamora deleted the dev/cazamor/stylus-support branch September 10, 2019 16:29
@ghost
Copy link

ghost commented Sep 24, 2019

🎉Windows Terminal Preview v0.5.2661.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add stylus support (selection)
5 participants