Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the boundaries of the scrolling commands #2505

Merged
merged 7 commits into from
Sep 11, 2019
Merged

Correct the boundaries of the scrolling commands #2505

merged 7 commits into from
Sep 11, 2019

Commits on Sep 9, 2019

  1. Correct the scroll clipping boundaries for the RI, DL, and IL commands.

    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    c8600f8 View commit details
    Browse the repository at this point in the history

  2. Correct the scroll clipping boundaries for the SU and SD commands.

    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    ea100df View commit details
    Browse the repository at this point in the history

  3. Correct the scroll clipping boundaries for the ICH and DCH commands, … 

    …and simplify the implementation.
    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    e3a9caa View commit details
    Browse the repository at this point in the history

  4. Convert the adapter tests into more appropriate screen buffer tests, … 

    …taking into account that scrolling now affects the full buffer width.
    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    bfe918e View commit details
    Browse the repository at this point in the history

  5. Extend the screen buffer scrolling tests to cover the IL, DL, and RI … 

    …commands.
    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    05b1a9b View commit details
    Browse the repository at this point in the history

  6. Get rid of the mock ScrollConsoleScreenBufferW implementation in the … 

    …adapter tests, since it's no longer needed.
    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    a917d0f View commit details
    Browse the repository at this point in the history

  7. Use gsl::narrow for narrowing casts, and document the inclusiveness o… 

    …f the scroll rects and the reason for using SHORT_MAX as a right boundary.
    @j4james
    j4james committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    f370a91 View commit details
    Browse the repository at this point in the history