Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to display toast with the CWD of the Terminal #15282

Merged
merged 15 commits into from
Jul 20, 2023

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented May 3, 2023

Adds an action to display a toast containing the Terminal's "virtual" CWD.

As described in #4637 (comment).

Useful for debugging #5506 et. al. I almost left it as a debug-only feature, but figured it would be helpful for others in the #4637 landscape of things.

  In the dirtiest way possible, this seems to work for most "start with this CWD" scenarios.
@zadjii-msft
Copy link
Member Author

show-cwd-action

@zadjii-msft zadjii-msft added Area-Commandline wt.exe's commandline arguments zBugBash-Consider labels May 4, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone May 4, 2023
@zadjii-msft

This comment was marked as resolved.

PKRoma pushed a commit to PKRoma/Terminal that referenced this pull request May 12, 2023
# Conflicts:
#	src/cascadia/TerminalApp/Resources/en-US/Resources.resw
#	src/cascadia/TerminalApp/TerminalPage.cpp
Base automatically changed from dev/migrie/b/5506-virtual-cwd to main May 12, 2023 18:20
@@ -511,6 +511,9 @@
<data name="OpenWindowRenamerCommandKey" xml:space="preserve">
<value>Rename window...</value>
</data>
<data name="DisplayWorkingDirectoryCommandKey" xml:space="preserve">
<value>Display Terminal's current working directory</value>
Copy link
Member

@DHowett DHowett May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too nuanced I think for users to get - it's a debugging feature, and it will NOT show the current working directory of the shell that is hosted in the current tab inside the Terminal. I might keep this one on the drawing board for 18

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DHowett What if I put this behind DebugFeaturesEnabled, like the "Break into debugger" action? At least in that case, "you must be this high to ride" applies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, name the action debugTerminalCwd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about both? In this case, I will consider debug to be the verb 😁

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label May 23, 2023
@microsoft-github-policy-service

This comment was marked as resolved.

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@zadjii-msft
Copy link
Member Author

shh I have more important things to be doing

@zadjii-msft zadjii-msft reopened this May 30, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels May 30, 2023
@zadjii-msft zadjii-msft removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label May 30, 2023
@zadjii-msft zadjii-msft merged commit 648d240 into main Jul 20, 2023
15 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/f/show-cwd branch July 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments zBugBash-Consider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants