Enable tearing out tabs to create new windows #14935

… 26 TODOs left

I think I have a vision for it now. 25 TODOs left.

It doesn't save or restore, but it does seem to not crash. 24 TODOs left

21 TODOs left

They weren't from the persisted JSON, but they did come back 21 TODOs left

… always work as expected 20 TODOs left

The trick is, that if you do this while debugging, the AppState will get persisted as you're stepping through, which can make debugging this really tricky

(cherry picked from commit 7bad8c9)

17 TODOs remain

16 TODOs

14 TODOs left

Down to just 10 TODOs left

…tor the WindowEmperor randomly now, which is no good

…e just dtor the WindowEmperor randomly now, which is no good" This reverts commit 7e91bdb.

3 TODOs left

2 TODOs left

…word

…ndale

…aquenta

…ta-silmarillion

…op/3/akallabeth

…ndale

…aquenta

…ta-silmarillion

…op/3/akallabeth

…don't rebuild themselves on move

(cherry picked from commit 4eba01f)

…ta-silmarillion

…don't rebuild themselves on move (cherry picked from commit 7d903de)

…op/3/akallabeth

Basically, because we were projecting the event straight trhough the control, from core->page, basically when we would do a PasteRequested, we'd call the handler registered on the first control, then also the handler added by the second.

…t ended up fixing this bug. All we actually needed was to do a _FontSizeChangedHandlers() to set up the font size and the markers in the TermControl.

…ta-silmarillion

…he boundary

…ndale

… do the part that fixed it

…and just do the part that fixed it" This reverts commit 667b658.

…aquenta

…ta-silmarillion

…works again

…op/3/akallabeth

This reverts commit b41ae71.

The incredibly dumb solution I considered. As previously outlined in #5000 (comment)

4 TODOs left

…hat we ALWAYS drag the 0th tab now. Peculiar.

1 TODOs left

(cherry picked from commit 7649725)

(cherry picked from commit b1a867d)

…word

…ndale

… work

…aquenta

…ta-silmarillion

…op/3/akallabeth

This was actually easy enough that I'm tempted to include it in the prior branches

…ndale

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

…rosoft/terminal into dev/migrie/oop/3/ainulindale

…shes we need

…ndale

…aquenta

…ta-silmarillion

(cherry picked from commit fda1663)

…op/3/akallabeth

…nexpected-party

… when updating settings

… when updating settings (cherry picked from commit 35c7474)

…aquenta

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

This removes all the weirdness around the way that TerminalPage needs to track the number of open windows. Instead of TerminalPage persisting empty state when the last tab closes, it lets the AppHost know that the last tab was closed due to _closing the tab_ (as opposed to closing the window / quitting). This gives AppHost an opportunity to persist empty state for that case, because _it_ knows how many windows there are. This could basically be its own PR. Probably worth xlinking this commit to #9800

…od amount

…ndale

…aquenta

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

…ta-silmarillion

…windows entirely failing to start

…word

…ndale

Each page was registering as a handoff target, so basically we'd start the server then yeet the connection back to the first window and presto, you'd have a dead window and a connection on the wrong thread and everything was awful. Instead, only register as the handoff listener when we've actually said we want to be a handoff listener.

(cherry picked from commit 805b880)

(cherry picked from commit b107f7d)

…lindale # Conflicts: # src/cascadia/TerminalApp/AppLogic.cpp # src/cascadia/TerminalApp/AppLogic.h # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/TerminalApp/TerminalPage.h # src/cascadia/TerminalApp/TerminalWindow.cpp # src/cascadia/TerminalApp/TerminalWindow.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp # src/cascadia/TerminalSettingsModel/GlobalAppSettings.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h

…to dev/migrie/oop/3/valaquenta

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

…lindale

…to dev/migrie/oop/3/valaquenta

…ta-silmarillion

…op/3/akallabeth

…ta-silmarillion

…op/3/akallabeth

…ta-silmarillion

If we get initialized with a window name, this will be called before XAML is stood up, and constructing a PropertyChangedEventArgs will throw. So don't.

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

…op/3/akallabeth

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

…tent in their settings

… That doesn't make sense.

…g panes. That doesn't make sense." This reverts commit 31e904a.

…en moving panes. That doesn't make sense."" This reverts commit a86fd20.

…op/3/akallabeth

…lion' into dev/migrie/oop/3/akallabeth

…osoft/terminal into dev/migrie/oop/3/akallabeth

…nexpected-party

(cherry picked from commit 3152ff9)

(cherry picked from commit 3f5a559)

….com/microsoft/terminal into dev/migrie/oop/3/quenta-silmarillion

…op/3/akallabeth

(cherry picked from commit ef4651a)

…nexpected-party

…ta-silmarillion

…op/3/akallabeth

…nexpected-party

…labeth # Conflicts: # src/cascadia/Remoting/Monarch.cpp # src/cascadia/Remoting/Monarch.h # src/cascadia/Remoting/Monarch.idl # src/cascadia/Remoting/Peasant.cpp # src/cascadia/Remoting/Peasant.h # src/cascadia/Remoting/Peasant.idl # src/cascadia/Remoting/WindowManager.cpp # src/cascadia/Remoting/WindowManager.h # src/cascadia/Remoting/WindowManager.idl # src/cascadia/TerminalApp/TerminalPage.cpp # src/cascadia/TerminalApp/TerminalPage.h # src/cascadia/TerminalApp/TerminalPage.idl # src/cascadia/TerminalApp/TerminalWindow.cpp # src/cascadia/TerminalApp/TerminalWindow.h # src/cascadia/TerminalApp/TerminalWindow.idl # src/cascadia/UnitTests_Remoting/RemotingTests.cpp # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h

…nexpected-party

…nexpected-party # Conflicts: # src/cascadia/Remoting/Monarch.h # src/cascadia/Remoting/Monarch.idl # src/cascadia/Remoting/WindowManager.h # src/cascadia/Remoting/WindowManager.idl # src/cascadia/TerminalApp/TabManagement.cpp # src/cascadia/TerminalApp/TerminalPage.cpp # src/cascadia/TerminalApp/TerminalPage.h # src/cascadia/UnitTests_Remoting/RemotingTests.cpp

Commits on Mar 27, 2023

Smaller PR nits

zadjii-msft committed Mar 27, 2023

Configuration menu

View commit details

Copy full SHA for 70fd182

Browse repository at this point

Copy the full SHA

70fd182 View commit details

Browse the repository at this point in the history

Commits on Mar 31, 2023

cammants

zadjii-msft committed Mar 31, 2023

Configuration menu

View commit details

Copy full SHA for 94865b8

Browse repository at this point

Copy the full SHA

94865b8 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable tearing out tabs to create new windows #14935

Enable tearing out tabs to create new windows #14935

Commits on Feb 8, 2023

Commits on Feb 9, 2023

Commits on Feb 10, 2023

Commits on Feb 11, 2023

Commits on Feb 13, 2023

Commits on Feb 14, 2023

Commits on Feb 15, 2023

Commits on Feb 16, 2023

Commits on Feb 17, 2023

Commits on Feb 21, 2023

Commits on Feb 22, 2023

Commits on Feb 23, 2023

Commits on Feb 27, 2023

Commits on Feb 28, 2023

Commits on Mar 2, 2023

Commits on Mar 6, 2023

Commits on Mar 7, 2023

Commits on Mar 8, 2023

Commits on Mar 9, 2023

Commits on Mar 10, 2023

Commits on Mar 13, 2023

Commits on Mar 14, 2023

Commits on Mar 17, 2023

Commits on Mar 20, 2023

Commits on Mar 21, 2023

Commits on Mar 22, 2023

Commits on Mar 23, 2023

Commits on Mar 24, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023