-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the DECRQM escape sequence #14444
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
51737fb
Return directly from each case in _ModeParamsHelper.
j4james 0518645
Convert internal dispatch modes into a shared enumset.
j4james 9bc9d43
Remove unneeded input mode methods.
j4james addcdad
Remove unneeded screen mode method.
j4james 0a713b8
Remove unneeded auto wrap mode method.
j4james 97b65ab
Remove unneeded cursor mode methods.
j4james e093732
Remove unneeded parser mode methods.
j4james 1bbb9ee
Remove unneeded SetColumns methods.
j4james e19b1c4
Remove unneeded alt buffer mode methods.
j4james 10bb3a0
Remove unneeded bracketed paste mode method.
j4james cb86db8
Add getter APIs for autowrap and bracketed paste.
j4james 339cefb
Update unit tests to account for API changes.
j4james 754429a
Add support for the DECRQM escape sequence.
j4james 9c837c1
Add support for the DECNKM mode.
j4james 8bd46d4
Add unit test for DECRQM.
j4james 1716df2
Apply PR feedback.
j4james 59e741f
Merge branch 'main' into feature-decrqm
j4james 298e698
Welcome back spelling-bot.
j4james File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we had to call both
SetBlinkingAllowed
andSetIsOn
whenever we changed the blinking state, so this just lets us do that more efficiently with a single call. The comment was copied fromEnableCursorBlinking
method, which was one of the places we were doing that, and which has now been removed as part of theITermDispatch
cleanup.