Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hiding the tab close button #13348

Merged
84 commits merged into from
Aug 1, 2022
Merged

Add support for hiding the tab close button #13348

84 commits merged into from
Aug 1, 2022

Commits on Mar 24, 2022

  1. Settings project builds at least

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    15e4fd9 View commit details
    Browse the repository at this point in the history

  2. this fixes the App bits as well

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7e0ae35 View commit details
    Browse the repository at this point in the history

  3. on reload, this changes the BG of the titlebar, but not the tab view

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    00c135b View commit details
    Browse the repository at this point in the history

  4. this is better. Apphost is gonna need to be involved anyways so fuck it

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    b4cd7b3 View commit details
    Browse the repository at this point in the history

  5. okay so i bet that resource changed. Whatever, we'll work with it.

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9627483 View commit details
    Browse the repository at this point in the history

  6. dumbly accept alpha channel in colors

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    84805f5 View commit details
    Browse the repository at this point in the history

  7. mica works, but the titlebar looks DUMB

    @zadjii-msft
    zadjii-msft committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9670d13 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. this did seem to work, but will it work for acrylic?

    @zadjii-msft
    zadjii-msft committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    c555e6e View commit details
    Browse the repository at this point in the history

  2. okay so you can't change a solid brush to an acylic one at runtime

    @zadjii-msft
    zadjii-msft committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    01f07be View commit details
    Browse the repository at this point in the history

  3. A pile of dead ends. 

    https://stackoverflow.com/questions/64694722/changing-themeresources-dynamically-in-uwp

That post looked SUPER promising. Problem is though, I CANNOT for the life of me
get that to work. Like, I can't get anything to `{Binding Brush, Mode=TwoWay,
Source={StaticResource TerminalBackground}}` to the `TerminalBackground` thing I
made there. I thought that was so clever.

I wanted an easy way to just change the value of a resource and have it update
the Titlebar, but since the Titlebar isn't a child of the TerminalPage, and this
binding thing didn't work, I think I'm at a dead end.
    @zadjii-msft
    zadjii-msft committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    ee9333a View commit details
    Browse the repository at this point in the history

  4. i feel like I'm getting closer

    @zadjii-msft
    zadjii-msft committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    9eff0a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. really, no good progress here. It's rough

    @zadjii-msft
    zadjii-msft committed Mar 28, 2022
    1 Configuration menu
    Copy the full SHA
    44112fc View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. We can't be clever here. Just make an observable property and slam th… 

    …e brush in there
    @zadjii-msft
    zadjii-msft committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f92724d View commit details
    Browse the repository at this point in the history

  2. guess what, it works

    @zadjii-msft
    zadjii-msft committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    cd0012a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. change color based on if the window is activated or now

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    1 Configuration menu
    Copy the full SHA
    ac49459 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    1 Configuration menu
    Copy the full SHA
    03211c8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/dev/migrie/titebar-colors' into … 

    …dev/migrie/fhl/theming-2022-prototype
    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1d0a5d7 View commit details
    Browse the repository at this point in the history

  4. accept accent color as a ThemeColor

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    e22046f View commit details
    Browse the repository at this point in the history

  5. this actually works now. Remember kids, break statements in switch/ca… 

    …ses are NOT optional
    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    99dc75d View commit details
    Browse the repository at this point in the history

  6. cleanup, works on start and when unset

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a7ce860 View commit details
    Browse the repository at this point in the history

  7. Lookup themes from a list of themes, use that one to style the window

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    4f42661 View commit details
    Browse the repository at this point in the history

  8. This is horrifying and yet I'm totally shipping it. Move the objects … 

    …to be sub-properties of the Theme
    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5081118 View commit details
    Browse the repository at this point in the history

  9. better, better,

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    fe26114 View commit details
    Browse the repository at this point in the history

  10. wow

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    1 Configuration menu
    Copy the full SHA
    7fcfda3 View commit details
    Browse the repository at this point in the history

  11. stragglers

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    1 Configuration menu
    Copy the full SHA
    df0efff View commit details
    Browse the repository at this point in the history

  12. hey this is easier

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    7243603 View commit details
    Browse the repository at this point in the history

  13. this is like 99% of the work here

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    606db76 View commit details
    Browse the repository at this point in the history

  14. switches when a tab does, not the pane

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    de22df0 View commit details
    Browse the repository at this point in the history

  15. I think that's everything

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    01d6907 View commit details
    Browse the repository at this point in the history

  16. Some minor todos

    @zadjii-msft
    zadjii-msft committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    39b6fdd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Some settings saving roundtripping bugs

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    9bebb74 View commit details
    Browse the repository at this point in the history

  2. Change theme with the SUI and actually have it persist

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    cfb99d9 View commit details
    Browse the repository at this point in the history

  3. include the themes

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a57187b View commit details
    Browse the repository at this point in the history

  4. Use better display names

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    b6b9aea View commit details
    Browse the repository at this point in the history

  5. This is horrifying

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    1 Configuration menu
    Copy the full SHA
    e2318b4 View commit details
    Browse the repository at this point in the history

  6. more comments

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    bc8bb8e View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    1 Configuration menu
    Copy the full SHA
    446e17b View commit details
    Browse the repository at this point in the history

  8. cleanup for the review

    @zadjii-msft
    zadjii-msft committed Apr 27, 2022
    1 Configuration menu
    Copy the full SHA
    fd2dd3a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. forgot you

    @zadjii-msft
    zadjii-msft committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    a1ea0fd View commit details
    Browse the repository at this point in the history

  2. spell

    @zadjii-msft
    zadjii-msft committed Apr 28, 2022
    1 Configuration menu
    Copy the full SHA
    9b9a644 View commit details
    Browse the repository at this point in the history

  3. runformat

    @zadjii-msft
    zadjii-msft committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    03da3b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    24f945a View commit details
    Browse the repository at this point in the history

  2. well, this is like all of it

    @zadjii-msft
    zadjii-msft committed Apr 29, 2022
    1 Configuration menu
    Copy the full SHA
    49c580c View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed May 3, 2022
    Configuration menu
    Copy the full SHA
    3281a3a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/fhl/theming-2022-prototype' into dev/migrie/… 

    …f/702-link-tab-to-terminal
    @zadjii-msft
    zadjii-msft committed May 3, 2022
    Configuration menu
    Copy the full SHA
    476c5bb View commit details
    Browse the repository at this point in the history

  3. this is REALLY janky but seems to work

    @zadjii-msft
    zadjii-msft committed May 3, 2022
    Configuration menu
    Copy the full SHA
    68d70a0 View commit details
    Browse the repository at this point in the history

  4. this is simpler

    @zadjii-msft
    zadjii-msft committed May 3, 2022
    Configuration menu
    Copy the full SHA
    99bc963 View commit details
    Browse the repository at this point in the history

  5. make the code a lot cleaner

    @zadjii-msft
    zadjii-msft committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6c28ba6 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Removes the ability to add Mica in the titlebar, but good enough for v0

    @zadjii-msft
    zadjii-msft committed May 4, 2022
    1 Configuration menu
    Copy the full SHA
    342eb2b View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed May 5, 2022
    Configuration menu
    Copy the full SHA
    cd2fd43 View commit details
    Browse the repository at this point in the history

  2. Fixes the Settings UI terminalBackground settings

    @zadjii-msft
    zadjii-msft committed May 5, 2022
    Configuration menu
    Copy the full SHA
    44319a1 View commit details
    Browse the repository at this point in the history

  3. this fixes the terminalBG + runtime change

    @zadjii-msft
    zadjii-msft committed May 5, 2022
    1 Configuration menu
    Copy the full SHA
    d73e450 View commit details
    Browse the repository at this point in the history

  4. well, this was part of it...

    @zadjii-msft
    zadjii-msft committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e52b7a9 View commit details
    Browse the repository at this point in the history

  5. derp

    @zadjii-msft
    zadjii-msft committed May 5, 2022
    1 Configuration menu
    Copy the full SHA
    3af471a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Add comments

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    1 Configuration menu
    Copy the full SHA
    b2abca6 View commit details
    Browse the repository at this point in the history

  2. Start by just adding a test file

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cae5218 View commit details
    Browse the repository at this point in the history

  3. Fill in more tests

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    45fb4b1 View commit details
    Browse the repository at this point in the history

  4. This is what I was looking for

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    28119c7 View commit details
    Browse the repository at this point in the history

  5. Fix having a null window, cause that was actually very possible

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    1 Configuration menu
    Copy the full SHA
    2712e46 View commit details
    Browse the repository at this point in the history

  6. sensible defaults

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    331b98f View commit details
    Browse the repository at this point in the history

  7. typos

    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    f38dc5c View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed May 6, 2022
    Configuration menu
    Copy the full SHA
    cb788b0 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Merge branch 'dev/migrie/fhl/theming-2022-prototype' into dev/migrie/… 

    …f/702-link-tab-to-terminal
    @zadjii-msft
    zadjii-msft committed May 9, 2022
    1 Configuration menu
    Copy the full SHA
    4f55646 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f5007fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/fhl/theming-2022-prototype' into dev/migrie/… 

    …f/702-link-tab-to-terminal
    @zadjii-msft
    zadjii-msft committed May 25, 2022
    1 Configuration menu
    Copy the full SHA
    87a9222 View commit details
    Browse the repository at this point in the history

  3. cleanup for review

    @zadjii-msft
    zadjii-msft committed May 25, 2022
    1 Configuration menu
    Copy the full SHA
    9c3b861 View commit details
    Browse the repository at this point in the history

  4. that's not even that bad

    @zadjii-msft
    zadjii-msft committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d9b383f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. the more important color thing

    @zadjii-msft
    zadjii-msft committed May 26, 2022
    Configuration menu
    Copy the full SHA
    861cd2a View commit details
    Browse the repository at this point in the history

  2. more nits and such

    @zadjii-msft
    zadjii-msft committed May 26, 2022
    Configuration menu
    Copy the full SHA
    c07b01e View commit details
    Browse the repository at this point in the history

  3. typo

    @zadjii-msft
    zadjii-msft committed May 26, 2022
    Configuration menu
    Copy the full SHA
    72904b9 View commit details
    Browse the repository at this point in the history

  4. this wouldn't happen if there was just an operator?.()

    @zadjii-msft
    zadjii-msft committed May 26, 2022
    Configuration menu
    Copy the full SHA
    c8254b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8d86538 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/fhl/theming-2022-prototype' into dev/migrie/… 

    …f/702-link-tab-to-terminal
    @zadjii-msft
    zadjii-msft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0e13b7b View commit details
    Browse the repository at this point in the history

  3. basically all of it

    @zadjii-msft
    zadjii-msft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    465f45d View commit details
    Browse the repository at this point in the history

  4. this works pretty dang well

    @zadjii-msft
    zadjii-msft committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    95790a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/themin… 

    …g-2022-prototype
    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    ee4ae62 View commit details
    Browse the repository at this point in the history

  2. just disable mica for now

    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9806d64 View commit details
    Browse the repository at this point in the history

  3. This is what happens when a PR has been open for ages

    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    4245964 View commit details
    Browse the repository at this point in the history

  4. nits across the board

    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9ab99b3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev/migrie/fhl/theming-2022-prototype' into dev/migrie/… 

    …f/702-link-tab-to-terminal
    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    a80dc6a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev/migrie/f/702-link-tab-to-terminal' into dev/migrie/… 

    …f/3335-tab-close-btn
    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    27ed738 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/f/3335-tab… 

    …-close-btn

# Conflicts:
#	src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp
#	src/cascadia/TerminalApp/AppLogic.cpp
#	src/cascadia/TerminalApp/AppLogic.h
#	src/cascadia/TerminalApp/TerminalPage.cpp
#	src/cascadia/TerminalApp/TerminalPage.h
#	src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp
#	src/cascadia/TerminalSettingsEditor/GlobalAppearance.h
#	src/cascadia/TerminalSettingsEditor/GlobalAppearance.idl
#	src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml
#	src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
#	src/cascadia/TerminalSettingsModel/MTSMSettings.h
#	src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h
#	src/cascadia/TerminalSettingsModel/Theme.cpp
#	src/cascadia/TerminalSettingsModel/Theme.h
#	src/cascadia/TerminalSettingsModel/Theme.idl
#	src/cascadia/WindowsTerminal/AppHost.cpp
    @zadjii-msft
    zadjii-msft committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    1ad6ef4 View commit details
    Browse the repository at this point in the history

  2. fix build breaks

    @zadjii-msft
    zadjii-msft committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9e75f67 View commit details
    Browse the repository at this point in the history

  3. the null deref we were talking about

    @zadjii-msft
    zadjii-msft committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    dab4501 View commit details
    Browse the repository at this point in the history