Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword bold enum options #10969

Merged
2 commits merged into from
Aug 20, 2021
Merged

Reword bold enum options #10969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70a42b6
reword
PankajBhojwani Aug 17, 2021
0fdb425
reword
PankajBhojwani Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,23 +1191,23 @@
<comment>Header for a control to how text is formatted</comment>
</data>
<data name="Appearance_IntenseTextStyle.Header" xml:space="preserve">
<value>Intense Text Format</value>
<value>Intense (Bold) Text Format</value>
<comment>Header for a control to select how "intense" text is formatted (bold, bright, both or none)</comment>
</data>
<data name="Appearance_IntenseTextStyleNone.Content" xml:space="preserve">
<value>None</value>
<comment>An option to choose from for the "intense text format" setting. When selected, "intense" text will not be rendered differently</comment>
</data>
<data name="Appearance_IntenseTextStyleBold.Content" xml:space="preserve">
<value>Bold</value>
<value>Show bold with a heavier font weight</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find this confusing: This option doesn't show bold text in a heavier font weight, it enables having any bold for intense text in the first place.
I also suspect this might lead to awkward translations. In Simplified Chinese this leads to "Show bold, font weight is heavier". German is alright, but has the same logical problem as the English variant.

In some way I liked the previous variant more. As far as I understood it none of the other terminals are that verbose about it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on something like "Show intense/bold with a heavier font weight"?

Also paging @cinnamon-msft for wording ideas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm fine with it being succinct.
"bold" is the technical term for "heavier font weight", so adding "intense" doesn't make it better in my opinion: It's still akin to "Show bold as bold".
I don't have a good idea for a better description than what we have now.

Copy link
Contributor

@cinnamon-msft cinnamon-msft Aug 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like:

Intense text style

  • Bold font
  • Bright colors
  • Bold font with bright colors
  • None

This follows what we have in the JSON plus it should indicate to the user what "intense" means when they see the options underneath.

Also do we need the "Text Formatting" header? I'm assuming this is under the Text category on the Profile Appearance page anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may just want to not offer none

this is also the first of possibly many format-specific options like "do italics work? do you want underlines to work? overlines?" I kinda.. don't hate that we have a section for it.

@cinnamon-msft FYI James did a quick comp against some of our peer terminals and found that they had slightly more verbose wording: #10955 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also the first of possibly many format-specific options like "do italics work?

crazy that you say that - it's exactly why I gave it a whole section. I could have sworn there was a feature request for "disable italics" but I couldn't find it.

<comment>An option to choose from for the "intense text format" setting. When selected, "intense" text will be rendered as bold text</comment>
</data>
<data name="Appearance_IntenseTextStyleBright.Content" xml:space="preserve">
<value>Bright</value>
<value>Show bold with brighter colors</value>
<comment>An option to choose from for the "intense text format" setting. When selected, "intense" text will be rendered in a brighter color</comment>
</data>
<data name="Appearance_IntenseTextStyleAll.Content" xml:space="preserve">
<value>Both</value>
<value>Show bold with brighter colors and a heavier font weight</value>
<comment>An option to choose from for the "intense text format" setting. When selected, "intense" text will be rendered as both bold text and in a brighter color</comment>
</data>
</root>