Prevent redraw upon resize if new size is equal to old #10895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Interaction
carlos-zamora
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Thanks! This seems reasonable to me. @zadjii-msft may want to take a look here though since he wrote it, I think.
zadjii-msft
approved these changes
Aug 9, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
DHowett
added
the
zPreview-Service-Queued-1.13
DHowett
pushed a commit
that referenced
this pull request
Aug 25, 2021
## Summary of the Pull Request Do not invoke terminal resize logic if view port dimensions didn't change ## PR Checklist * [x] Closes #10857 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Short-circuit `ControlCore::_doResizeUnderLock` if the dimensions of the required view port are equal to the dimensions of the current view port
DHowett
removed
the
zPreview-Service-Queued-1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Do not invoke terminal resize logic if view port dimensions didn't change
PR Checklist
Detailed Description of the Pull Request / Additional comments
Short-circuit
ControlCore::_doResizeUnderLockif the dimensions of therequired view port are equal to the dimensions of the current view port