Use WinRT VirtualKeyModifiers instead of a custom enum

[mimvdb]

Replaces KeyModifiers with the pretty much equivalent
VirtualKeyModifiers enum in winrt.

After doing this I noticed #10593 which changes the KeyChords a lot, but
it seems these PRs are still compatible

The issue also mentions replacing Vkey with
Windows::System::VirtualKey, but I chose not to because that enum only
includes a subset of the keys terminal supports here (no VK_OEM_* keys)

Validation Steps Performed

Changed key bind in config, and confirmed it still works after
restarting terminal

Closes #877

[lhecker]

This PR removes the need for ConvertVKModifiers. Nice. 👍
If you want to you could write

using VirtualKeyModifiers = winrt::Windows::System::VirtualKeyModifiers;

here and there, to shorten the code lines, but I'm fine with merging as it is.

[DHowett]

So, our initial design for the terminal settings model was intended to avoid a dependency on the Windows.UI namespace-- it is a big namespace that we may not want consumers to depend on.

@zadjii-msft and @carlos-zamora may have opinions.

[DHowett]

(At the same time, thanks for the contribution! It's good to have you here :))

[lhecker]

@DHowett Isn't VirtualKeyModifiers part of the Windows.System namespace?

[mimvdb]

Windows.UI is used in several places in the terminal settings model. For example, in ActionArgs Windows::UI::Color for TabColor. The Windows.System namespace does seem te be new, although winrt/Windows.System.h is included in the pch.

[DHowett]

Windows.UI is used in several places in the terminal settings model. For example, in ActionArgs Windows::UI::Color for TabColor. The Windows.System namespace does seem te be new, although winrt/Windows.System.h is included in the pch.

@DHowett Dustin Howett FTE Isn't VirtualKeyModifiers part of the Windows.System namespace?

Shows what I get for triaging pull requests on my phone and not reading their bodies. Thanks all! This looks fine to me, but I'd prefer @zadjii-msft sign off.

---

@msftbot make sure @zadjii-msft signs off

[DHowett]

@msftbot make sure @zadjii-msft signs off

[ghost]

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I'll only merge this pull request if it's approved by @zadjii-msft

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[carlos-zamora]

Just a minor suggestion.

I'll probably run into a few conflicts on my end with adding a key chord listener to the actions page in SUI, but that's my problem, not yours haha.

[ghost]

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download