Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup from bell flash PR #10307

Merged
2 commits merged into from
Jun 2, 2021
Merged

Cleanup from bell flash PR #10307

2 commits merged into from
Jun 2, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jun 1, 2021 •
edited by DHowett
Loading

Just come cleanup I did not manage to get to before #9270 merged.

Specifically:

  • We only initialize the animation and timer if we need them
  • We don't repeatedly destroy/create the timer

Validation Steps Performed

It still works

DHowett
DHowett approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it doesn't crash!

@PankajBhojwani PankajBhojwani added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 2, 2021
@ghost
Copy link

ghost commented Jun 2, 2021

Hello @PankajBhojwani!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2fed4c4 into main Jun 2, 2021
@ghost ghost deleted the dev/pabhoj/bell_cleanup branch June 2, 2021 18:49
DHowett pushed a commit that referenced this pull request Jul 7, 2021
@PankajBhojwani @DHowett
Cleanup from bell flash PR (#10307)
50acd89 
Just come cleanup I did not manage to get to before #9270 merged.

Specifically:

- We only initialize the animation and timer if we need them
- We don't repeatedly destroy/create the timer

## Validation Steps Performed
It still works

(cherry picked from commit 2fed4c4)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PankajBhojwani @DHowett @lhecker