Prevent crashes in Settings UI launch on OS versions before package management extensions #10238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default conhost is always returned as one element. Change the model to hold a nullptr DefaultTerminal model representation even if that fails because XAML is A-OK with nullptr and will select no item as Current but will crash out if it gets an exception.
ghost
added
Area-DefApp
Area-Settings UI
DHowett
approved these changes
May 27, 2021
zadjii-msft
approved these changes
May 27, 2021
miniksa
added
zPreview-Service-Queued-1.13
|
Hello @miniksa! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 49 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot wait 1 minute before merging |
|
Hello @miniksa! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
DHowett
pushed a commit
that referenced
this pull request
Jun 1, 2021
…anagement extensions (#10238) Prevent crashes in Settings UI launch on OS versions before package management extensions ## PR Checklist * [x] Closes #10106 * [x] I work here * [x] Manual tests passed. ## Detailed Description of the Pull Request / Additional comments - On older OS versions like 18363, some of the COM interfaces we use to look up information from the OS application package management catalog (to find default terminals) are unavailable. This returns `E_NOINTERFACE`. This then ends up returning an empty list of items and null as a selected item. - I had intended for that to not return that particular error all the way up and just log it because the console and terminal lookup functions always return at least one element: the one representing the `conhost.exe` that is already on the machine. - I have changed the "default packages" lookup to log instead of return failures like E_NOINTERFACE such that it can continue processing and make the "package" of the hardcoded `conhost.exe` default no matter what. (It will still return an error if there are somehow 0 packages because that code changed or some other catastrophic event happened...) - I have also changed the Model to have a nulled DefaultTerminal model object (as all winrt objects are nullable) instead of using an optional. I did this because XAML is perfectly happy receiving a `nullptr` for a selected item and will just not select anything. By contrast, if it has an exception occur... it will just bubble that out and crash. ## Validation Steps Performed - Simulated no items returned from list and nullptr returned to XAML on Current() method of Model. Validated XAML will happily select no item from list (and is fine with an empty list of items... that is it doesn't crash). - Simulated downlevel OS returning package management errors in lookup catalog functions after the hardcoded default is added to the list. Ensured that this error is only logged, the remainder of the package identification functions make the hardcoded default package, and it is presented as your one and only option in the XAML. (cherry picked from commit b2c2a4c)
DHowett
removed
the
zPreview-Service-Queued-1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent crashes in Settings UI launch on OS versions before package management extensions
PR Checklist
Detailed Description of the Pull Request / Additional comments
E_NOINTERFACE. This then ends up returning an empty list of items and null as a selected item.conhost.exethat is already on the machine.conhost.exedefault no matter what. (It will still return an error if there are somehow 0 packages because that code changed or some other catastrophic event happened...)nullptrfor a selected item and will just not select anything. By contrast, if it has an exception occur... it will just bubble that out and crash.Validation Steps Performed