Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestWindowRename unit tests are failing #9769

Closed
j4james opened this issue Apr 10, 2021 · 2 comments · Fixed by #9815
Closed

TestWindowRename unit tests are failing #9769

j4james opened this issue Apr 10, 2021 · 2 comments · Fixed by #9815
Assignees
@zadjii-msft
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.9

Comments

@j4james
Copy link
Collaborator

j4james commented Apr 10, 2021

Windows Terminal version (or Windows build number)

10.0.18363.1379, 7f5a19b

Other Software

No response

Steps to reproduce

Build the app and run the unit tests (runut.cmd).

Expected Behavior

All the tests should pass.

Actual Behavior

The two TestWindowRename tests cause TAEF to crash.

TAEF: A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in process "TestHostApp.exe" (pid:11864).
Error: TAEF: [HRESULT 0x800706BE] A failure occurred while running a test operation: 'TerminalAppLocalTests::TabTests::TestWindowRenameSuccessful'. (A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in the process hosting the test code while invoking a test operation.)
EndGroup: TerminalAppLocalTests::TabTests::TestWindowRenameSuccessful [Failed]

TAEF: A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in process "TestHostApp.exe" (pid:9296).
Error: TAEF: [HRESULT 0x800706BE] A failure occurred while running a test operation: 'TerminalAppLocalTests::TabTests::TestWindowRenameFailure'. (A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in the process hosting the test code while invoking a test operation.)
EndGroup: TerminalAppLocalTests::TabTests::TestWindowRenameFailure [Failed]
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 10, 2021
@j4james
Copy link
Collaborator Author

j4james commented Apr 10, 2021

In case this isn't easily reproducible, and you need more details, this is the full log leading up to the crash for TestWindowRenameSuccessful:

StartGroup: TerminalAppLocalTests::TabTests::TestWindowRenameSuccessful
Verify: IsNotNull(settings0)
Construct the TerminalPage
Verify: SUCCEEDED(result)
Verify: IsNotNull(page)
Verify: IsNotNull(page->_settings)
Create() the TerminalPage
Verify: IsNotNull(page)
Verify: IsNotNull(page->_settings)
Create()'d the page successfully
Added a single newTab action
Verify: SUCCEEDED(result)
Wait for the page to finish initializing...
Verify: SUCCEEDED(waitForInitEvent.Wait())
...Done
Ensure we set the first tab as the selected one.
Verify: SUCCEEDED(result)
Verify: AreEqual(1u, page->_tabs.Size())
Verify: SUCCEEDED(result)
TAEF: A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in process "TestHostApp.exe" (pid:11864).

And this is for TestWindowRenameFailure:

StartGroup: TerminalAppLocalTests::TabTests::TestWindowRenameFailure
Verify: IsNotNull(settings0)
Construct the TerminalPage
Verify: SUCCEEDED(result)
Verify: IsNotNull(page)
Verify: IsNotNull(page->_settings)
Create() the TerminalPage
Verify: IsNotNull(page)
Verify: IsNotNull(page->_settings)
Create()'d the page successfully
Added a single newTab action
Verify: SUCCEEDED(result)
Wait for the page to finish initializing...
Verify: SUCCEEDED(waitForInitEvent.Wait())
...Done
Ensure we set the first tab as the selected one.
Verify: SUCCEEDED(result)
Verify: AreEqual(1u, page->_tabs.Size())
Verify: SUCCEEDED(result)
TAEF: A crash with exception code 0xC0000005 occurred in module "TerminalApp.LocalTests.dll" in process "TestHostApp.exe" (pid:9296).

@zadjii-msft
Copy link
Member

oh no, I'll take a look. Thanks!

@zadjii-msft zadjii-msft self-assigned this Apr 12, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.8 milestone Apr 12, 2021
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 12, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 12, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 13, 2021
@zadjii-msft zadjii-msft mentioned this issue Apr 14, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 14, 2021
@ghost ghost closed this as completed in #9815 Apr 14, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 14, 2021
ghost pushed a commit that referenced this issue Apr 14, 2021
@zadjii-msft
Fix the renamer tests (#9815)
4941084 
## Summary of the Pull Request

Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load.

## References
* broken in in #9662
* 
## PR Checklist
* [x] Closes #9769
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

For whatever reason, these tests are unhappy running back to back, but are just fine running isolated.
mpela81 pushed a commit to mpela81/terminal that referenced this issue Apr 17, 2021
@zadjii-msft @mpela81
Fix the renamer tests (microsoft#9815)
d9f6dcf 
## Summary of the Pull Request

Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load.

## References
* broken in in microsoft#9662
* 
## PR Checklist
* [x] Closes microsoft#9769
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

For whatever reason, these tests are unhappy running back to back, but are just fine running isolated.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.9
Development

Successfully merging a pull request may close this issue.

Fix the renamer tests microsoft/terminal
3 participants
@DHowett @j4james @zadjii-msft