Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection is still super busted in 1.8 / main #9725

Closed
zadjii-msft opened this issue Apr 6, 2021 · 4 comments
Closed

Selection is still super busted in 1.8 / main #9725

zadjii-msft opened this issue Apr 6, 2021 · 4 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.8

Comments

@zadjii-msft
Copy link
Member

Windows Terminal version (or Windows build number)

1.8.921.0

Other Software

No response

Steps to reproduce

  • Make a selection
  • release the mouse
  • Click somewhere inside the terminal, outside the original selection
  • drag the mouse, as to create a new selection

Expected Behavior

We should start a new selection

Actual Behavior

The original selection dismisses, but a new one doesn't start :(

@Don-Vito as an FYI
@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Apr 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.8 milestone Apr 6, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 6, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 6, 2021
@Don-Vito
Copy link
Contributor

Don-Vito commented Apr 6, 2021

@zadjii-msft - I will try to take a look.. but I guess I will be able to get to the actual fix only on the weekend

@Don-Vito
Copy link
Contributor

Don-Vito commented Apr 6, 2021

OK. I see the bug.. I am such a noob 😭

@Don-Vito Don-Vito mentioned this issue Apr 6, 2021
Merged
24 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Apr 6, 2021
@ghost ghost closed this as completed in e80e9b9 Apr 6, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 6, 2021
DHowett pushed a commit that referenced this issue Apr 7, 2021
@Don-Vito @DHowett
Fix marking of new selection start (#9727)
7b6625d 
## PR Checklist
* [x] Closes #9725
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

## Validation Steps Performed
* [x] single click = no selection
* [x] single click and drag = selection starting from first point
* [x] single click in unfocused pane and drag = focus pane, selection starting from first point
* [x] double-click = selects a whole word
* [x] triple-click = selects a whole line
* [x] double-click and drag = selects a whole word, drag selects whole words
* [x] triple-click and drag = selects a whole line, drag selects whole lines
* [x] Shift single-click = defines start point
* [x] second Shift single-click = defines end point
* [x] Shift double-click = selects entire word
* [x] Shift triple-click = selects entire line
* [x] Shift double-click and drag = selects entire word, drag selects whole words
* [x] Mouse mode: Shift single-click = defines start point
* [x] Mouse mode: second Shift single-click = defines end point
* [x] Mouse mode: Shift double-click = selects entire word
* [x] Mouse mode: Shift triple-click = selects entire line
* [x] Mouse mode: Shift double-click and drag = selects entire word, drag selects whole words
* [x] With existing selection: single-click outside the selection and drag = establishes a new selection starting from the click point

(cherry picked from commit e80e9b9)
zadjii-msft added a commit that referenced this issue Apr 7, 2021
@zadjii-msft
A test for #9725
f959612
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9727, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9727, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.8
Development

No branches or pull requests
2 participants
@Don-Vito @zadjii-msft