Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGQUIT is sent to terminal when switching to non-existent tab #9635

Closed
Christilut opened this issue Mar 27, 2021 · 3 comments · Fixed by #9781
Closed

SIGQUIT is sent to terminal when switching to non-existent tab #9635

Christilut opened this issue Mar 27, 2021 · 3 comments · Fixed by #9781
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@Christilut
Copy link

Windows Terminal version (or Windows build number)

1.6.10571.0

Other Software

Ubuntu 18.04.3 LTS

GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)

Steps to reproduce

I use tabs in Windows Terminal by using CTRL+number (eg CTRL+3 goes to tab 3).
When there is a running command in bash (eg sleep 10 for demo purposes) and I switch to a tab that does not exist (eg CTRL+4 when there are 3 open tabs), the process is exited with a SIGQUIT signal.

Expected Behavior

Nothing should happen when pressing the hotkey to go to a tab that does not exist

Actual Behavior

chris@pc:~/workspace$ sleep 10
^\Quit

Process is terminated when pressing CTRL+4
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 27, 2021
@DHowett
Copy link
Member

DHowett commented Mar 29, 2021 •
edited
Loading

So, this is an interesting case! We implemented this on purpose for a bunch of different key bindings. When they don't act, they pass the input through. The one we really, really wanted to get right for Windows users was Ctrl+C. Copy if there's a selection (and they've bound it to copy), send a literal ETX if not.

We can probably adjust the "switch to tab" key bindings to mark the binding as handled even if there's no tab at that index with relative ease.

Thanks!

@DHowett DHowett added Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. labels Mar 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 29, 2021
@DHowett DHowett added this to the Terminal v1.8 milestone Mar 29, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 29, 2021
@Don-Vito Don-Vito mentioned this issue Apr 12, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 12, 2021
@ghost ghost closed this as completed in #9781 Apr 12, 2021
@ghost ghost removed the In-PR This issue has a related PR label Apr 12, 2021
ghost pushed a commit that referenced this issue Apr 12, 2021
@Don-Vito
Handle switch to tab binding even if tab doesn't exist (#9781)
a9a58f7 
Closes #9635
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 12, 2021
DHowett pushed a commit that referenced this issue Apr 12, 2021
@Don-Vito @DHowett
Handle switch to tab binding even if tab doesn't exist (#9781)
e40b5e8 
Closes #9635

(cherry picked from commit a9a58f7)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9781, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9781, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Handle switch to tab binding even if tab doesn't exist Don-Vito/terminal
3 participants
@DHowett @Christilut @zadjii-msft