Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TerminalSettings interfaces #7140

Closed
carlos-zamora opened this issue Jul 31, 2020 · 0 comments · Fixed by #7167
Closed

Move TerminalSettings interfaces #7140

carlos-zamora opened this issue Jul 31, 2020 · 0 comments · Fixed by #7167
Assignees
@carlos-zamora
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

  • Move TerminalSettings::ICoreSettings to TerminalControl project
  • Move TerminalSettings::IControlSettings to TerminalControl project

TerminalSettings will continue to be an ICoreSettings and IControlSettings and will be used normally.

See #885 and #6904 for more details.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jul 31, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@carlos-zamora carlos-zamora self-assigned this Jul 31, 2020
@carlos-zamora carlos-zamora added this to the Terminal v1.3 milestone Jul 31, 2020
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Jul 31, 2020
Closed
4 tasks
@carlos-zamora carlos-zamora mentioned this issue Aug 3, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 3, 2020
@ghost ghost closed this as completed in #7167 Aug 7, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 7, 2020
ghost pushed a commit that referenced this issue Aug 7, 2020
@carlos-zamora
Move ICore/ControlSettings to TerminalControl project (#7167)
1c6aa4d 
## Summary of the Pull Request
Move `ICoreSettings` and `IControlSettings` from the TerminalSettings project to the TerminalCore and TerminalControl projects respectively. Also entirely removes the TerminalSettings project.

The purpose of these interfaces is unchanged. `ICoreSettings` is used to instantiate a terminal. `IControlSettings` (which requires an `ICoreSettings`) is used to instantiate a UWP terminal control.

## References
Closes #7140 
Related Epic: #885 
Related Spec: #6904 

## PR Checklist
* [X] Closes #7140 
* [X] CLA signed
* [X] Tests ~added~/passed (no additional tests necessary)
* [X] ~Documentation updated~
* [X] ~Schema updated~

## Detailed Description of the Pull Request / Additional comments
A lot of the work here was having to deal with winmd files across all of these projects. The TerminalCore project now outputs a Microsoft.Terminal.TerminalControl.winmd. Some magic happens in TerminalControl.vcxproj to get this to work properly.

## Validation Steps Performed
Deployed Windows Terminal and opened a few new tabs.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Move ICore/ControlSettings to TerminalControl project microsoft/terminal
1 participant
@carlos-zamora