Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tooltip text when terminal is maximized #5693

Closed
encladeus opened this issue May 1, 2020 · 7 comments · Fixed by #9412
Closed

Incorrect tooltip text when terminal is maximized #5693

encladeus opened this issue May 1, 2020 · 7 comments · Fixed by #9412
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@encladeus
Copy link

Environment

Windows build number: [10.0.18363.778]
Windows Terminal version (if applicable): Current master 44689b93

Any other software? No

Steps to reproduce

Open terminal and maximize the window.
Hover the mouse over the restore button.

Expected behavior

Displays the tooltip Restore Down

Actual behavior

Displays the tooltip Maximize
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 1, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels May 1, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 1, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 1, 2020
@DHowett-MSFT
Copy link
Contributor

Yup.

@DHowett-MSFT
Copy link
Contributor

We knew this was a problem when we first added automation text (for accessibility).

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2020
@Chips1234
Copy link
Contributor

Yes, it should be "restore down". I couldn't figure out how to do that.

@Chips1234
Copy link
Contributor

Is there a possibility that we can use the system default buttons? They come with tooltips.

@DHowett
Copy link
Member

DHowett commented May 25, 2020

There is no possibility of us using the system buttons. :(

@ghost ghost mentioned this issue Oct 8, 2020
Closed
@Chips1234 Chips1234 mentioned this issue Mar 8, 2021
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 8, 2021
@ghost ghost closed this as completed in #9412 Mar 9, 2021
@ghost ghost removed the In-PR This issue has a related PR label Mar 9, 2021
ghost pushed a commit that referenced this issue Mar 9, 2021
@Chips1234
Display correct tooltip when window is maximized (#9412)
8358f8d 
## Summary of the Pull Request
Instead of displaying "Maximize" in the tooltip for the maximize/restore button even when the window is maximized, it now displays "Restore Down".

## References
Fixes #5693

## PR Checklist
* [X] Closes #5693
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed

## Validation Steps Performed
Tested manually.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 9, 2021
DHowett pushed a commit that referenced this issue Mar 15, 2021
@Chips1234 @DHowett
Display correct tooltip when window is maximized (#9412)
c8be59f 
## Summary of the Pull Request
Instead of displaying "Maximize" in the tooltip for the maximize/restore button even when the window is maximized, it now displays "Restore Down".

## References
Fixes #5693

## PR Checklist
* [X] Closes #5693
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed

## Validation Steps Performed
Tested manually.

(cherry picked from commit 8358f8d)
DHowett pushed a commit that referenced this issue Mar 15, 2021
@Chips1234 @DHowett
Display correct tooltip when window is maximized (#9412)
1481475 
## Summary of the Pull Request
Instead of displaying "Maximize" in the tooltip for the maximize/restore button even when the window is maximized, it now displays "Restore Down".

## References
Fixes #5693

## PR Checklist
* [X] Closes #5693
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed

## Validation Steps Performed
Tested manually.

(cherry picked from commit 8358f8d)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9412, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9412, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Display correct tooltip when window is maximized Chips1234/terminal
5 participants
@DHowett @encladeus @DHowett-MSFT @zadjii-msft @Chips1234